Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize the situation around WebSocketRequest and its usage #105

Open
redlickigrzegorz opened this issue Nov 17, 2024 · 0 comments
Open

Comments

@redlickigrzegorz
Copy link
Collaborator

redlickigrzegorz commented Nov 17, 2024

Maybe we can create a similar Event class to the one we have for REST? It should simplify the work with it 😉

Originally posted by @redlickigrzegorz in #102 (comment)

It would be nice to confirm the documentation that you used as I see that all these keys are under context 🤷

Originally posted by @redlickigrzegorz in #102 (comment)

I started thinking whether these two classes are really that similar to inherit from the same base one 🤔

Originally posted by @redlickigrzegorz in #102 (comment)

This line should be removed after the changes you made.

Originally posted by @redlickigrzegorz in #102 (comment)

It looks like we should allow passing body=None instead of ignoring the error.

Originally posted by @redlickigrzegorz in #102 (comment)

def test__json_body__raises_error_when_json_is_malformed(self) -> None:

Originally posted by @redlickigrzegorz in #102 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant