Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename config items to be more organized #914

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Conversation

frostming
Copy link
Collaborator

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

Merging #914 (f0293e2) into main (b37a3ec) will decrease coverage by 0.42%.
The diff coverage is 77.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #914      +/-   ##
==========================================
- Coverage   84.11%   83.68%   -0.43%     
==========================================
  Files          74       74              
  Lines        6426     6448      +22     
  Branches     1321     1332      +11     
==========================================
- Hits         5405     5396       -9     
- Misses        703      738      +35     
+ Partials      318      314       -4     
Flag Coverage Δ
unittests 83.45% <77.41%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pdm/cli/actions.py 79.88% <ø> (ø)
pdm/installers/installers.py 83.92% <ø> (ø)
pdm/project/core.py 89.91% <66.66%> (ø)
pdm/cli/commands/config.py 90.19% <72.22%> (-1.30%) ⬇️
pdm/project/config.py 93.44% <80.00%> (-2.72%) ⬇️
pdm/installers/synchronizers.py 86.81% <100.00%> (ø)
pdm/models/setup.py 42.29% <0.00%> (-10.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b37a3ec...f0293e2. Read the comment docs.

@frostming frostming merged commit 39a6a6e into main Feb 16, 2022
@frostming frostming deleted the feature/rename-configs branch February 16, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants