Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDM should not automatically update pyproject.toml #867

Closed
canatella opened this issue Jan 24, 2022 · 1 comment
Closed

PDM should not automatically update pyproject.toml #867

canatella opened this issue Jan 24, 2022 · 1 comment
Labels
🐛 bug Something isn't working

Comments

@canatella
Copy link

  • [X ] I have searched the issue tracker and believe that this is not a duplicate.

So I'm preparing to upgrade our dev environment and I'm installing the release 1.12.6 and suddenly I see that PDM modifies my project's pyproject.toml which in turns prevent me from deploying because we enforce a policy to never deploy uncommitted code. I understand the point of doing this but not the means. Could we avoid in the future modifying source code without user intervention ? A prominent warning would be a good enough solution I think. I don't like my code being modified without my knowledge ;)

Make sure you run commands with -v flag before pasting the output.

Steps to reproduce

Run pdm on a project with version = {use_scm = true} under [project]

Actual behavior

PDM moves the version declaration to the new location under tool.

Expected behavior

PDM should warn about the bad location but it should not change source code unless askedfor.

@canatella canatella added the 🐛 bug Something isn't working label Jan 24, 2022
@canatella
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant