-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pdm show specific package with werid output #580
Fix pdm show specific package with werid output #580
Conversation
pdm/models/project_info.py
Outdated
|
||
|
||
def get_as_dot_list(metadata: DistributionMetadata, key: str) -> List[str]: | ||
return metadata.get(key, "").split(",") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this function necessary? It does the same as keywords = metadata.get("keywords", "").replace(",", ", ")
, or just don't replace, use it as is.
Codecov Report
@@ Coverage Diff @@
## main #580 +/- ##
=======================================
Coverage 84.05% 84.06%
=======================================
Files 68 68
Lines 5563 5566 +3
Branches 980 981 +1
=======================================
+ Hits 4676 4679 +3
Misses 614 614
Partials 273 273
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Check List
news/
describing what is new.Describe what you have changed in this PR.
Run the command
pdm show xxx
to print specific package info. It got weird output instead.Run
pdm show pdm
Or run
pdm show colorama
This PR resolves all the above issues.