Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use installer as the wheel installer #519

Closed
frostming opened this issue Jun 24, 2021 · 0 comments · Fixed by #563
Closed

Use installer as the wheel installer #519

frostming opened this issue Jun 24, 2021 · 0 comments · Fixed by #563
Labels
⭐ enhancement Improvements for existing features

Comments

@frostming
Copy link
Collaborator

frostming commented Jun 24, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

PDM is now using distlib as the wheel installer, which is a more strict installer than the implementation of pip: it validates the files in the zip ball against the RECORDS file and aborts if invalid. This will often surprise users in many cases (#500 for instance).

Describe the solution you'd like

Replace the installer with the dedicated project installer. Maybe after https://github.com/pradyunsg/installer/pull/63/ is merged and released.
@frostming frostming added the ⭐ enhancement Improvements for existing features label Jun 24, 2021
This was referenced Jul 23, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⭐ enhancement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use installer as the wheel installer pdm-project/pdm
1 participant
@frostming