Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a default requires-python on import #1426

Merged
merged 2 commits into from
Oct 8, 2022

Conversation

frostming
Copy link
Collaborator

@frostming frostming commented Oct 8, 2022

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Resolve #1416

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2022

Codecov Report

Base: 85.52% // Head: 85.53% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (61e314e) compared to base (dc5ee70).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1426   +/-   ##
=======================================
  Coverage   85.52%   85.53%           
=======================================
  Files          87       87           
  Lines        7571     7575    +4     
  Branches     1774     1775    +1     
=======================================
+ Hits         6475     6479    +4     
  Misses        714      714           
  Partials      382      382           
Flag Coverage Δ
unittests 85.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/cli/actions.py 80.14% <100.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit a9589c3 into main Oct 8, 2022
@frostming frostming deleted the feat/default-requires-python branch October 8, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not clear why this is a version conflict
2 participants