Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an override option to the env_file script option #1299

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

pgjones
Copy link
Contributor

@pgjones pgjones commented Aug 3, 2022

This allows the user to specify that the env_file should override any
existing environment variables. This is not the default as the
environment the code runs it should take precedence.

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@pgjones
Copy link
Contributor Author

pgjones commented Aug 3, 2022

The test failures seem unrelated.

@pgjones pgjones force-pushed the main branch 3 times, most recently from 4e2c970 to 030343a Compare August 4, 2022 12:46
Copy link
Collaborator

@frostming frostming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor issue. Could you also add some docs in docs/usage/script.md?

This allows the user to specify that the env_file should override any
existing environment variables. This is not the default as the
environment the code runs it should take precedence.
@pgjones
Copy link
Contributor Author

pgjones commented Aug 4, 2022

I've added docs as well.

@frostming frostming merged commit 950885f into pdm-project:main Aug 4, 2022
@pgjones
Copy link
Contributor Author

pgjones commented Aug 4, 2022

Thanks

@choinhet
Copy link

image
this is not working for me :(
neither if I do start.env_file for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants