Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haplomerger deps not on PATH #5

Closed
makopyan opened this issue Jan 21, 2022 · 1 comment
Closed

Haplomerger deps not on PATH #5

makopyan opened this issue Jan 21, 2022 · 1 comment

Comments

@makopyan
Copy link

makopyan commented Jan 21, 2022

The haplomerger perl scripts call the binaries in software/LepAnchor/deps/ubuntu/ but they aren't on the PATH, so it fails.

Solution Options:

  1. Create install script that creates the conda environment and moves the binaries to the conda bin/ directory
  2. Track down the binaries in the perl scripts and make them relative paths (least friction)
  3. Users manually perform cp software/LepAnchor/deps/ubuntu* /path/to/conda/env/bin/
@pdimens
Copy link
Owner

pdimens commented Jan 22, 2022

Hopefully fixed with 3.5 release. The attempt at a reasonable solution was to put logic into the LepWrap bash wrapper to check if it is being run inside a conda environment, and if it is, copy the lastz binaries into the conda env's binaries folder. This may pose an issue for the rare case of having a systemwide sudo-priveledged conda environment used by someone without sudo rights, but the cp logic only copies files that don't already exist in the destination. In such a case, an admin would have to intervene once and it wouldn't be a constant issue, I think.

@pdimens pdimens closed this as completed Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants