From edbf09513bddb2d7b8637a494c9f9a7d94fc3740 Mon Sep 17 00:00:00 2001
From: Paul Colby <git@colby.id.au>
Date: Tue, 29 Oct 2024 20:20:49 +1100
Subject: [PATCH] Default empty destructors

---
 include/qtpokit/calibrationservice.h | 2 +-
 include/qtpokit/dataloggerservice.h  | 2 +-
 include/qtpokit/deviceinfoservice.h  | 2 +-
 include/qtpokit/dsoservice.h         | 2 +-
 include/qtpokit/multimeterservice.h  | 2 +-
 src/lib/calibrationservice.cpp       | 8 --------
 src/lib/dataloggerservice.cpp        | 8 --------
 src/lib/deviceinfoservice.cpp        | 8 --------
 src/lib/dsoservice.cpp               | 8 --------
 src/lib/multimeterservice.cpp        | 8 --------
 10 files changed, 5 insertions(+), 45 deletions(-)

diff --git a/include/qtpokit/calibrationservice.h b/include/qtpokit/calibrationservice.h
index 41cd17777..e9fc4349b 100644
--- a/include/qtpokit/calibrationservice.h
+++ b/include/qtpokit/calibrationservice.h
@@ -40,7 +40,7 @@ class QTPOKIT_EXPORT CalibrationService : public AbstractPokitService
     };
 
     CalibrationService(QLowEnergyController * const pokitDevice, QObject * parent = nullptr);
-    ~CalibrationService() override;
+    ~CalibrationService() = default;
 
     bool readCharacteristics() override;
 
diff --git a/include/qtpokit/dataloggerservice.h b/include/qtpokit/dataloggerservice.h
index 5a2979c9b..39df35944 100644
--- a/include/qtpokit/dataloggerservice.h
+++ b/include/qtpokit/dataloggerservice.h
@@ -94,7 +94,7 @@ class QTPOKIT_EXPORT DataLoggerService : public AbstractPokitService
     typedef QVector<qint16> Samples;
 
     DataLoggerService(QLowEnergyController * const pokitDevice, QObject * parent = nullptr);
-    ~DataLoggerService() override;
+    ~DataLoggerService() = default;
 
     bool readCharacteristics() override;
     bool readMetadataCharacteristic();
diff --git a/include/qtpokit/deviceinfoservice.h b/include/qtpokit/deviceinfoservice.h
index 92fb01250..175586f98 100644
--- a/include/qtpokit/deviceinfoservice.h
+++ b/include/qtpokit/deviceinfoservice.h
@@ -56,7 +56,7 @@ class QTPOKIT_EXPORT DeviceInfoService : public AbstractPokitService
     };
 
     DeviceInfoService(QLowEnergyController * const pokitDevice, QObject * parent = nullptr);
-    ~DeviceInfoService() override;
+    ~DeviceInfoService() = default;
 
     bool readCharacteristics() override;
     bool readFirmwareRevisionCharacteristic();
diff --git a/include/qtpokit/dsoservice.h b/include/qtpokit/dsoservice.h
index 2ac695d5d..9e82e6ebc 100644
--- a/include/qtpokit/dsoservice.h
+++ b/include/qtpokit/dsoservice.h
@@ -94,7 +94,7 @@ class QTPOKIT_EXPORT DsoService : public AbstractPokitService
     typedef QVector<qint16> Samples;
 
     DsoService(QLowEnergyController * const pokitDevice, QObject * parent = nullptr);
-    ~DsoService() override;
+    ~DsoService() = default;
 
     bool readCharacteristics() override;
     bool readMetadataCharacteristic();
diff --git a/include/qtpokit/multimeterservice.h b/include/qtpokit/multimeterservice.h
index 708535368..730f65e17 100644
--- a/include/qtpokit/multimeterservice.h
+++ b/include/qtpokit/multimeterservice.h
@@ -83,7 +83,7 @@ class QTPOKIT_EXPORT MultimeterService : public AbstractPokitService
     };
 
     MultimeterService(QLowEnergyController * const pokitDevice, QObject * parent = nullptr);
-    ~MultimeterService() override;
+    ~MultimeterService() = default;
 
     bool readCharacteristics() override;
     bool readReadingCharacteristic();
diff --git a/src/lib/calibrationservice.cpp b/src/lib/calibrationservice.cpp
index 6e5408950..f95b9783f 100644
--- a/src/lib/calibrationservice.cpp
+++ b/src/lib/calibrationservice.cpp
@@ -39,14 +39,6 @@ CalibrationService::CalibrationService(
 }
 /// \endcond
 
-/*!
- * Destroys this CalibrationService object.
- */
-CalibrationService::~CalibrationService()
-{
-
-}
-
 /*!
  * \copybrief AbstractPokitService::readCharacteristics
  *
diff --git a/src/lib/dataloggerservice.cpp b/src/lib/dataloggerservice.cpp
index 5cd7bedba..1fa44c584 100644
--- a/src/lib/dataloggerservice.cpp
+++ b/src/lib/dataloggerservice.cpp
@@ -128,14 +128,6 @@ DataLoggerService::DataLoggerService(
 }
 /// \endcond
 
-/*!
- * Destroys this DataLoggerService object.
- */
-DataLoggerService::~DataLoggerService()
-{
-
-}
-
 bool DataLoggerService::readCharacteristics()
 {
     return readMetadataCharacteristic();
diff --git a/src/lib/deviceinfoservice.cpp b/src/lib/deviceinfoservice.cpp
index 5fd3bdd31..fc09e3968 100644
--- a/src/lib/deviceinfoservice.cpp
+++ b/src/lib/deviceinfoservice.cpp
@@ -38,14 +38,6 @@ DeviceInfoService::DeviceInfoService(
 }
 /// \endcond
 
-/*!
- * Destroys this DeviceInfoService object.
- */
-DeviceInfoService::~DeviceInfoService()
-{
-
-}
-
 bool DeviceInfoService::readCharacteristics()
 {
     const bool r1 = readFirmwareRevisionCharacteristic();
diff --git a/src/lib/dsoservice.cpp b/src/lib/dsoservice.cpp
index 4e8cae422..5e69d3e97 100644
--- a/src/lib/dsoservice.cpp
+++ b/src/lib/dsoservice.cpp
@@ -121,14 +121,6 @@ DsoService::DsoService(
 }
 /// \endcond
 
-/*!
- * Destroys this DsoService object.
- */
-DsoService::~DsoService()
-{
-
-}
-
 bool DsoService::readCharacteristics()
 {
     return readMetadataCharacteristic();
diff --git a/src/lib/multimeterservice.cpp b/src/lib/multimeterservice.cpp
index 90088117d..cffd9dbd4 100644
--- a/src/lib/multimeterservice.cpp
+++ b/src/lib/multimeterservice.cpp
@@ -144,14 +144,6 @@ MultimeterService::MultimeterService(
 }
 /// \endcond
 
-/*!
- * Destroys this MultimeterService object.
- */
-MultimeterService::~MultimeterService()
-{
-
-}
-
 bool MultimeterService::readCharacteristics()
 {
     return readReadingCharacteristic();