-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
importing the module itself in setup.py breaks install #35
Comments
Yes you are right, sorry. I copied the approach taken in another project, but there, the corresponding |
checkout current master. If it fixed the issue for you just close this issue.. thanks |
The version import in __init__.py should be relative, the rest looks fine to me. Edit: or the correct absolute import: |
yep, done. thanks. |
In 4c0e887 the line
import urwidtrees
was (re-)added to setup.py.Now
python setup.py install
imports urwid before installing it as a dependency and raisesImportError: No module named urwid
.This was fixed in #29 where other things got broken. Sorry for that!
I can create a PR, just thought some clarification and opinions first ;)
A recommended approach is to place the version in a separate file. E.g. urwidtrees/version.py:
Then read and execute it in setup.py:
and import it in urwidtrees/__init__.py to get
urwidtrees.__version__
:Further reading: http://stackoverflow.com/questions/458550/standard-way-to-embed-version-into-python-package
The version.py (maybe meta_info.py?) could also contain
__author__
,__description__
, etc. to have it all in a single place and inside the module.The text was updated successfully, but these errors were encountered: