Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync releases between pypi and github #24

Closed
TomasTomecek opened this issue Jan 5, 2016 · 5 comments
Closed

sync releases between pypi and github #24

TomasTomecek opened this issue Jan 5, 2016 · 5 comments

Comments

@TomasTomecek
Copy link

Looking at PyPI I can see there is a 1.0.1.1 release while on github there is just 1.0. Would it be possible to have those in a sync?

@pazz
Copy link
Owner

pazz commented Jan 5, 2016 via email

@TomasTomecek
Copy link
Author

oh wow, didn't know that (really confusing when you are mentioned as Author and this git as upstream)

will try to check what's different in both versions

@TomasTomecek
Copy link
Author

I can see that PyPI version contains fix for #22:

diff --git a/urwidtrees/__init__.py b/urwidtrees/__init__.py
index 13762bf..41293ea 100644
--- a/urwidtrees/__init__.py
+++ b/urwidtrees/__init__.py
@@ -1,11 +1,6 @@
-__productname__ = 'urwidtrees'
-__version__ = '1.0'
-__copyright__ = "Copyright (C) 2015 Patrick Totzke"
-__author__ = "Patrick Totzke"
-__author_email__ = "patricktotzke@gmail.com"
-__description__ = "Tree widgets for urwid"
-__url__ = "https://github.com/pazz/urwidtrees"
-__license__ = "Licensed under the GNU GPL v3+."
+from .version import (__productname__, __version__, __copyright__,
+                      __author_email__, __author__, __description__,
+                      __url__, __license__)

 from .tree import Tree, SimpleTree
 from .decoration import DecoratedTree, CollapsibleTree
diff --git a/setup.py b/setup.py
index d0804f3..9ff7674 100755
--- a/setup.py
+++ b/setup.py
@@ -1,17 +1,16 @@
 #!/usr/bin/env python

 from distutils.core import setup
-import urwidtrees
+import urwidtrees.version as v


 setup(name='urwidtrees',
-      version=urwidtrees.__version__,
-      description=urwidtrees.__description__,
-      author=urwidtrees.__author__,
-      author_email=urwidtrees.__author_email__,
-      url=urwidtrees.__url__,
-      license=urwidtrees.__copyright__,
+      version=v.__version__,
+      description=v.__description__,
+      author=v.__author__,
+      author_email=v.__author_email__,
+      url=v.__url__,
+      license=v.__copyright__,
       packages=['urwidtrees'],
       requires=['urwid (>=1.1.0)'],
-      provides='urwidtrees',
      )
diff --git a/urwidtrees/version.py b/urwidtrees/version.py
new file mode 100644
index 0000000..d81ae3c
--- /dev/null
+++ b/urwidtrees/version.py
@@ -0,0 +1,8 @@
+__productname__ = 'urwidtrees'
+__version__ = '1.0.1.1'
+__copyright__ = "Copyright (C) 2015 Patrick Totzke"
+__author__ = "Patrick Totzke"
+__author_email__ = "patricktotzke@gmail.com"
+__description__ = "Tree widgets for urwid"
+__url__ = "https://github.com/pazz/urwidtrees"
+__license__ = "Licensed under the GNU GPL v3+."

It also contains this patch:

diff --git a/urwidtrees/widgets.py b/urwidtrees/widgets.py
index c286675..1247234 100644
--- a/urwidtrees/widgets.py
+++ b/urwidtrees/widgets.py
@@ -76,6 +76,7 @@ class TreeListWalker(urwid.ListWalker):

     def set_focus(self, pos):
         self._focus = pos
+        self._modified()

     def get_next(self, pos):
         return self._get(self._tree.next_position(pos))

It also contains README.md and docs/.

@pazz
Copy link
Owner

pazz commented Jan 10, 2016

the second patch seems to be already included in upstream master.
I have no opinion on the first patch. This is how i handled meta info in alot and just copied it to this project. I'm reluctant to include this one.

@TomasTomecek
Copy link
Author

Okay, thanks for update. Since you are not maintaining the PyPI repo there's not much we can discuss here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants