Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary files in UM config_files list. #419

Closed
MartinDix opened this issue Feb 19, 2024 · 3 comments
Closed

Unnecessary files in UM config_files list. #419

MartinDix opened this issue Feb 19, 2024 · 3 comments
Assignees

Comments

@MartinDix
Copy link
Contributor

The config_files list includes a number of files that the model doesn't actually use. Model configurations would be clearer without the duplicated namelists. See coecms/access-esm#14

@aidanheerdegen
Copy link
Collaborator

A simple change would be to move them to the optional_config_files

https://github.com/payu-org/payu/blob/master/payu/models/um.py#L48

@aidanheerdegen aidanheerdegen self-assigned this Apr 9, 2024
@blimlim
Copy link
Contributor

blimlim commented Jun 28, 2024

I've had a go at removing the extra files listed here in a branch of payu (also thanks to @jo-basevi for helping get this working). In addition to shortening the um.py config list, I had to remove the following lines:

payu/payu/models/um.py

Lines 144 to 150 in 8a4a1e2

# The above needs to be done in parexe also.
# FIXME: a better way to do this or remove.
parexe = os.path.join(self.work_path, 'parexe')
for line in fileinput.input(parexe, inplace=True):
line = line.format(input_path=self.input_paths[0],
work_path=self.work_path)
print(line, end='')

As far as I can tell, parexe is empty (at least in the pre-industrial configuration), and it appears to remain so after these lines are run. I just wanted to get confirmation that this would be safe to do, as I'm unsure of the original purpose of parexe.


Removing the extra config files and running for a few months produces identical simulations to unmodified configurations. The following shows the difference in surface temperature for a simulation with the configuration files removed and one without, on March 31:

download-5


If this sounds ok I'll add pull requests to add the changes to payu and the configurations.

@blimlim
Copy link
Contributor

blimlim commented Jul 4, 2024

Closing this issue and have added a new one to remove the extra files in the configurations.

@blimlim blimlim closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants