Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed final keywoards from PaymillContext and ClientService #57

Closed
wants to merge 1 commit into from

Conversation

dobermai
Copy link

In order to properly mock these classes they must not be final since popular mocking frameworks like Mockito don't allow mocking of final classes.

Also, ClientService is the only service which is final so this PR removes this inconsistency.

…r to improve testability (mocking!) of these classes
stoilkov added a commit that referenced this pull request Oct 2, 2014
@stoilkov
Copy link
Contributor

stoilkov commented Oct 2, 2014

thanks @dobermai , this was merged with #60

@stoilkov stoilkov closed this Oct 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants