perf: Call update_env only once per Markdown instance
#201
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The follow-up calls for each block make no difference at all, and are getting quite expensive.
|
Easy change for improved perfs, merging! Thanks @oprypin! |
jdpatt
added a commit
to jdpatt/mkdocstrings
that referenced
this pull request
Jan 6, 2023
Instead of a boolean of has any env been updated, track by handle name which env has been updated. References: mkdocstrings#201 Fixes: 502
jdpatt
added a commit
to jdpatt/mkdocstrings
that referenced
this pull request
Jan 9, 2023
Instead of a boolean of has any env been updated, track by handle name which env has been updated. References: mkdocstrings#201 Fixes: 502
pawamoy
pushed a commit
that referenced
this pull request
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The follow-up calls for each block make no difference at all, and are getting quite expensive.