Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.10.1 won't install with latest pymdown-extensions #74

Closed
ofek opened this issue Apr 5, 2020 · 6 comments
Closed

0.10.1 won't install with latest pymdown-extensions #74

ofek opened this issue Apr 5, 2020 · 6 comments

Comments

@ofek
Copy link
Contributor

ofek commented Apr 5, 2020

We've been using the latest releases squidfunk/mkdocs-material#1498

mkdocs-material>=5.0.0rc4
pymdown-extensions>=7.0b2

which should both release officially this week.

However, this pins using carets https://python-poetry.org/docs/dependency-specification/#caret-requirements

https://github.com/pawamoy/mkdocstrings/blob/09791898dea482e307e3fb16bb503843d5eac3ef/pyproject.toml#L25
https://github.com/pawamoy/mkdocstrings/blob/09791898dea482e307e3fb16bb503843d5eac3ef/pyproject.toml#L37

Let's increase the range

https://python-poetry.org/docs/dependency-specification/#multiple-requirements
@pawamoy
Copy link
Member

pawamoy commented Apr 5, 2020 •
edited
Loading

If it works, sure, let's do that :)

Do you suggest pymdown-extensions = ">=6.3, <8.0" and mkdocs-material = ">=4.5, <6.0"?

@ofek
Copy link
Contributor Author

ofek commented Apr 5, 2020

Yup that will work!

@ofek
Copy link
Contributor Author

ofek commented Apr 5, 2020

https://facelessuser.github.io/pymdown-extensions/about/release/#upgrading-to-70
https://deploy-preview-1486--mkdocs-material-preview.netlify.com/releases/5/

@ofek
Copy link
Contributor Author

ofek commented Apr 7, 2020

They both were just released!

@pawamoy
Copy link
Member

pawamoy commented Apr 7, 2020

Alright, I'll publish a new release as well 🙂

pawamoy added a commit that referenced this issue Apr 7, 2020
@pawamoy
build: Increase range for dependencies
1a06632 
`mkdocs-material` and `pymdown-extensions`
recently released major versions which are compatible
with the current code.

Reference: issue #74.
@pawamoy
Copy link
Member

pawamoy commented Apr 7, 2020

Released 0.10.2!

@pawamoy pawamoy closed this as completed Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pawamoy @ofek