Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not Windows-compatible code in loggers #166

Closed
pawamoy opened this issue Oct 23, 2020 · 0 comments · Fixed by #172
Closed

Not Windows-compatible code in loggers #166

pawamoy opened this issue Oct 23, 2020 · 0 comments · Fixed by #172
Labels
bug Something isn't working logging Related logging messages

Comments

@pawamoy
Copy link
Member

pawamoy commented Oct 23, 2020

Describe the bug

In https://github.com/pawamoy/mkdocstrings/blob/master/src/mkdocstrings/loggers.py#L107:

return template.filename.rsplit("/templates/", 1)[1]

The forward slashes are not cross-platform 😉

Additional context
We should probably use os.sep instead of / here.
@pawamoy pawamoy added bug Something isn't working logging Related logging messages labels Oct 23, 2020
oprypin added a commit to oprypin/mkdocstrings that referenced this issue Nov 1, 2020
@oprypin
fix: Detecting paths relative to template directory in logging
1c82e2f 
Fixes mkdocstrings#166
@oprypin oprypin mentioned this issue Nov 1, 2020
Merged
oprypin added a commit to oprypin/mkdocstrings that referenced this issue Nov 1, 2020
@oprypin
fix: Detecting paths relative to template directory in logging
bdca622 
Fixes mkdocstrings#166
oprypin added a commit to oprypin/mkdocstrings that referenced this issue Nov 1, 2020
@oprypin
fix: Detecting paths relative to template directory in logging
a50046b 
Fixes mkdocstrings#166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working logging Related logging messages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Detecting paths relative to template directory in logging oprypin/mkdocstrings
1 participant
@pawamoy