Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS macros not expanded in Import nodes #99

Closed
nitrocaster opened this issue Mar 1, 2020 · 0 comments
Closed

VS macros not expanded in Import nodes #99

nitrocaster opened this issue Mar 1, 2020 · 0 comments

Comments

@nitrocaster
Copy link

I'm trying to use this tool on my project. Here's a piece of log that I get:

pi@nitrocaster-pi:~/git/eagleview/src $ cmake-converter -s eagleview.sln
0.000383 processes count = 4
0.000592 warnings level = 2
0.016914 WARN : Solution architecture is x86 and may be mapped onto Win32 at projects.To avoid problems rename x86 -> Win32.
0.017142 WARN : Solution architecture is x86 and may be mapped onto Win32 at projects.To avoid problems rename x86 -> Win32.
0.241204 1> Conversion started: Project eagleview
0.242412 2> Conversion started: Project tinyxml2
0.304976 2> WARN : file or path "/home/pi/git/eagleview/externals/$(SolutionDir)Common.props" not found.
0.305275 2> WARN : getting actual filesystem name failed : "/home/pi/git/eagleview/externals/$(SolutionDir)Common.props"
0.403407 2> Conversion done   : Project tinyxml2 (4 warnings)
(...)

From the log it seems that cmakeconverter doesn't expand $(SolutionDir) when parsing the following node in vcxproj file:
<Import Project="$(SolutionDir)Common.props" />

In ../externals/CMakeLists.txt I found this line, which indeed contains unexpanded SolutionDir macro:
use_props(${PROJECT_NAME} "${CMAKE_CONFIGURATION_TYPES}" "$(SolutionDir)Common.cmake")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant