Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #4

Merged
merged 25 commits into from
Jun 21, 2023
Merged

Bugfix #4

merged 25 commits into from
Jun 21, 2023

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Jun 21, 2023

  • Add header-only deps and Catch2 to external/
  • Fix broken tests
  • Skip "ALL" chromosome when looping over BinTable
  • Fix windows builds
  • Bugfix in utils to detect whether file is Cooler
  • Fix reading/writing bool HDF5 attributes

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #4 (787491f) into main (43f68a1) will decrease coverage by 0.19%.
The diff coverage is 67.61%.

❗ Current head 787491f differs from pull request most recent head e865145. Consider uploading reports for the commit e865145 to get more accurate results

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   81.09%   80.90%   -0.19%     
==========================================
  Files          50       49       -1     
  Lines        3285     3289       +4     
==========================================
- Hits         2664     2661       -3     
- Misses        621      628       +7     
Impacted Files Coverage Δ
src/cooler/dataset_write_impl.hpp 86.95% <ø> (ø)
src/hic/hic_file_utils_impl.hpp 66.66% <0.00%> (-33.34%) ⬇️
src/hic/include/hictk/hic/block_reader.hpp 100.00% <ø> (ø)
src/pixel/include/hictk/pixel.hpp 100.00% <ø> (ø)
src/cooler/attribute_impl.hpp 75.92% <40.00%> (-4.08%) ⬇️
src/hic/file_reader_impl.hpp 80.40% <40.00%> (+0.94%) ⬆️
src/hic/block_cache_impl.hpp 63.49% <55.55%> (-12.98%) ⬇️
src/chromosome/chromosome_impl.hpp 94.11% <66.66%> (-1.89%) ⬇️
src/cooler/validation_impl.hpp 86.06% <66.66%> (-5.28%) ⬇️
src/hic/hic_file_impl.hpp 89.13% <82.60%> (-2.42%) ⬇️
... and 5 more

... and 13 files with indirect coverage changes

@robomics robomics merged commit 3072cb8 into main Jun 21, 2023
13 of 16 checks passed
@robomics robomics deleted the bugfix branch June 21, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant