Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to iterators #253

Merged
merged 14 commits into from
Sep 15, 2024
Merged

Minor changes to iterators #253

merged 14 commits into from
Sep 15, 2024

Conversation

robomics
Copy link
Contributor

No description provided.

@robomics robomics added the enhancement New feature or request label Sep 15, 2024
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 70.21277% with 14 lines in your changes missing coverage. Please review.

Project coverage is 74.39%. Comparing base (365f138) to head (e27022c).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
..._table/include/hictk/impl/bin_table_fixed_impl.hpp 46.66% 3 Missing and 5 partials ⚠️
...nclude/hictk/cooler/impl/dataset_iterator_impl.hpp 71.42% 0 Missing and 4 partials ⚠️
...ble/include/hictk/impl/bin_table_variable_impl.hpp 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   74.52%   74.39%   -0.13%     
==========================================
  Files         144      144              
  Lines       12434    12459      +25     
  Branches     1445     1449       +4     
==========================================
+ Hits         9266     9269       +3     
- Misses       1989     1998       +9     
- Partials     1179     1192      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit 79f25b6 into main Sep 15, 2024
55 of 57 checks passed
@robomics robomics deleted the fix/iters branch September 15, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant