Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when fetching normalized interactions as dense matrices #252

Merged
merged 5 commits into from
Sep 15, 2024
Merged

Fix bug when fetching normalized interactions as dense matrices #252

merged 5 commits into from
Sep 15, 2024

Commits on Sep 15, 2024

  1. Refactor

    @robomics
    robomics committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    c2d44a5 View commit details
    Browse the repository at this point in the history

  2. Change how dense matrices are initialized 

    The main motivation behind this is to mask bad bins during matrix construction.
This fixes a bug found by the new fuzzer, where divisive weights with value 0
were not always handled correctly.
    @robomics
    robomics committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    5afe5e5 View commit details
    Browse the repository at this point in the history

  3. Bugfix

    @robomics
    robomics committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    a399491 View commit details
    Browse the repository at this point in the history

  4. Improve test coverage

    @robomics
    robomics committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    33ff9ab View commit details
    Browse the repository at this point in the history

  5. Ensure dense matrix is created as RowMajor from the get go 

    [no ci]
    @robomics
    robomics committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    e4d0e4f View commit details
    Browse the repository at this point in the history