Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly mask rows and columns when fetching balanced pixels as dense matrices #248

Closed
wants to merge 4 commits into from

Conversation

robomics
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 84.90566% with 8 lines in your changes missing coverage. Please review.

Project coverage is 74.63%. Comparing base (784477d) to head (b42d6c7).

Files with missing lines Patch % Lines
...e/hictk/transformers/impl/to_dense_matrix_impl.hpp 81.81% 3 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
+ Coverage   74.58%   74.63%   +0.05%     
==========================================
  Files         144      144              
  Lines       12059    12117      +58     
  Branches     1385     1399      +14     
==========================================
+ Hits         8994     9044      +50     
- Misses       1946     1949       +3     
- Partials     1119     1124       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics added the bug Something isn't working label Sep 13, 2024
[no ci]
@robomics
Copy link
Contributor Author

Closing in favor of #251.

@robomics robomics closed this Sep 14, 2024
@robomics robomics deleted the fix/fetch-matrices branch September 14, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant