Skip to content
This repository has been archived by the owner on May 9, 2023. It is now read-only.

Support for all map options #1

Open
beasteers opened this issue Jul 19, 2021 · 2 comments
Open

Support for all map options #1

beasteers opened this issue Jul 19, 2021 · 2 comments

Comments

@beasteers
Copy link

beasteers commented Jul 19, 2021

Mainly I'm interested in setting a default zoom and center, but I don't see why you couldn't just pass the field options transparently to the map constructor. There are a bunch of options that let you customize interactivity and they could be nice to have.

Time permitting, I may submit a PR.

Options API Reference: https://developers.google.com/maps/documentation/javascript/reference/map#MapOptions

Also, I'm NOT talking about having all of those options in the settings panel on the entry edit page (and having to create UI for it), but just have them globally set on the collection field type edit page (in that arbitrary json body)

@pauloamgomes
Copy link
Owner

You are right, this was implemented a long time ago and I stayed with the initial implementation. For several reasons I was not able to continue my contributions to Cockpit.. anyway, I'm happy to review a PR.

thanks

@beasteers
Copy link
Author

beasteers commented Jul 19, 2021

no worries I figured it's been out of mind for a while haha. We'll see when I have time to get to it haha. But thanks so much for this addon!

@beasteers beasteers changed the title Feature Request: Support all map options Support for all map options Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants