From a4053e027dbc94b940fc9eea3fddc2ae56818ce7 Mon Sep 17 00:00:00 2001 From: machenbach Date: Mon, 18 Jul 2016 02:19:15 -0700 Subject: [PATCH] Revert of Add force_dynamic_crt to build as static library but with /MD on windows (patchset #3 id:40001 of https://codereview.chromium.org/2149963002/ ) Reason for revert: Fails gyp build with chromium: https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/37051 Blocks roll: https://codereview.chromium.org/2157903002/ Please add the trybot ios-simulator on reland. Original issue's description: > [build] Add force_dynamic_crt option to build a static library with /MD on windows > > Adds option to build a V8 library statically, but with the options on > windows that allows it to be subsequently included in another DLL. On > Windows this is required for it to correclty link against the correct > C++ runtime. Require for our Node.js shared library build. > > Reference: https://github.com/nodejs/node/pull/7487 > > BUG= > R=machenbach@chromium.org, michael_dawson@ca.ibm.com > > Committed: https://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5d > Cr-Commit-Position: refs/heads/master@{#37814} TBR=michael_dawson@ca.ibm.com,franzih@chromium.org,sxa@uk.ibm.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2155073002 Cr-Commit-Position: refs/heads/master@{#37822} --- gypfiles/standalone.gypi | 1 - gypfiles/toolchain.gypi | 6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/gypfiles/standalone.gypi b/gypfiles/standalone.gypi index be2f1ee49f58..85f0029aab10 100644 --- a/gypfiles/standalone.gypi +++ b/gypfiles/standalone.gypi @@ -33,7 +33,6 @@ 'includes': ['toolchain.gypi'], 'variables': { 'component%': 'static_library', - 'force_dynamic_crt%': 0, 'clang_xcode%': 0, # Track where uninitialized memory originates from. From fastest to # slowest: 0 - no tracking, 1 - track only the initial allocation site, 2 diff --git a/gypfiles/toolchain.gypi b/gypfiles/toolchain.gypi index 56b62b2da8ce..a85c6607d0ae 100644 --- a/gypfiles/toolchain.gypi +++ b/gypfiles/toolchain.gypi @@ -1110,7 +1110,7 @@ 'VCCLCompilerTool': { 'Optimization': '0', 'conditions': [ - ['component=="shared_library" or force_dynamic_crt==1', { + ['component=="shared_library"', { 'RuntimeLibrary': '3', # /MDd }, { 'RuntimeLibrary': '1', # /MTd @@ -1162,7 +1162,7 @@ 'StringPooling': 'true', 'BasicRuntimeChecks': '0', 'conditions': [ - ['component=="shared_library" or force_dynamic_crt==1', { + ['component=="shared_library"', { 'RuntimeLibrary': '3', #/MDd }, { 'RuntimeLibrary': '1', #/MTd @@ -1353,7 +1353,7 @@ 'FavorSizeOrSpeed': '0', 'StringPooling': 'true', 'conditions': [ - ['component=="shared_library" or force_dynamic_crt==1', { + ['component=="shared_library"', { 'RuntimeLibrary': '2', #/MD }, { 'RuntimeLibrary': '0', #/MT