Refactoring unit testing

Author: pattisahusiwa

phpunit.xml.dist

@@ -3,7 +3,7 @@
 
   <testsuites>
     <testsuite name="alltest">
-      <file>tests/AllTests.php</file>
+      <directory suffix="Test.php">tests/Sniffs</directory>
     </testsuite>
   </testsuites>
 </phpunit>

tests/AllTests.php

@@ -1,4 +1,5 @@
-<?php
+<?php declare(strict_types=1);
+
 $myArray  ['key']            = $value;
 $myArray[ 'key']            = $value;
 $myArray['key' ]            = $value;

tests/CSAbstractSniffUnitTest.php

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 $array = array ();
 

tests/CSTestEntity.php

@@ -1,7 +1,3 @@
-<?php
+<?php declare(strict_types=1);
 
 $var = 'Hello'. ' World';
-
-// No Error
-$var = 'Hello'
-        . ' World';

tests/Inc/Arrays/ArrayBracketSpacing.inc

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 $var  = "Hello world!";
 $var = "Hello $there";

tests/Inc/Arrays/ArrayDeclaration.inc

@@ -1,3 +1,3 @@
-<?php
+<?php declare(strict_types=1);
 
 echo('hello');

tests/Inc/Strings/ConcatenationSpacing.inc

@@ -1,3 +1,3 @@
-<?php
+<?php declare(strict_types=1);
 
-$var = ( int ) "1";
+$var = ( int ) '1';

tests/Inc/Strings/DoubleQuoteUsage.inc

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 function MyFunction1()
 {

tests/Inc/Strings/EchoedStrings.inc

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 class Test
 {
@@ -22,4 +22,4 @@ function testA()
 function testB()
 {}
 
-echo 'test';
+$a = new stdClass();

tests/Inc/WhiteSpace/CastSpacing.inc

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 require$blah;
 require  $blah;

tests/Inc/WhiteSpace/FunctionOpeningBraceSpace.inc

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 if ($foo|| $bar) {}
 if ($foo ||$bar) {}

tests/Inc/WhiteSpace/FunctionSpacing.inc

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 class Testing
 {

tests/Inc/WhiteSpace/LanguageConstructSpacing.inc

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 $this ->testThis();
 $this-> testThis();

tests/Inc/WhiteSpace/LogicalOperatorSpacing.inc

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 
 $varA= 1 + 2;
 $varA =1 + 2;

tests/Inc/WhiteSpace/MemberVarSpacing.inc

@@ -1,4 +1,5 @@
-<?php
+<?php declare(strict_types=1);
+
     /**
     * Block comment
     */

tests/Inc/WhiteSpace/ObjectOperatorSpacing.inc

@@ -0,0 +1,58 @@
+<?php declare(strict_types=1);
+
+namespace PhpCodeConv\Tests\Sniffs;
+
+use PHPUnit\Framework\TestCase;
+
+abstract class AbstractTestCase extends TestCase
+{
+
+    /** @var Validator */
+    private static $validator;
+
+    abstract protected function getFilename() : string;
+
+    /** @phpstan-ignore-next-line */
+    final public function __construct($name = null, array $data = [], $dataName = '')
+    {
+        parent::__construct($name, $data, $dataName);
+    }
+
+    /** @return string[] */
+    protected function getExcludeSniff() : array
+    {
+        return [];
+    }
+
+    /** @return void */
+    final public static function setUpBeforeClass()
+    {
+        self::$validator = new Validator();
+
+        $filepath = dirname(__DIR__) . '/Inc/' . (new static)->getFilename();
+
+        self::$validator->setFile($filepath, (new static)->getExcludeSniff());
+    }
+
+    /** @return void */
+    final public static function tearDownAfterClass()
+    {
+        if (self::$validator->errorCount() > 0) {
+            printf("\n\n");
+            self::$validator->printError();
+        }
+
+        self::assertEquals(0, self::$validator->errorCount());
+    }
+
+    /** @return void */
+    final protected function checkSniff(int $line, int $column, string $sniff, string $message)
+    {
+        $key = SniffEntity::createKey($line, $column, $sniff);
+
+        $this->assertTrue(self::$validator->hasKey($key));
+        $this->assertSame($message, self::$validator->getMessage($key));
+
+        self::$validator->removeItem($key);
+    }
+}