Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageGroup - remove deprecated sticky prop #152

Closed
evwilkin opened this issue Dec 7, 2022 · 0 comments · Fixed by #185
Closed

PageGroup - remove deprecated sticky prop #152

evwilkin opened this issue Dec 7, 2022 · 0 comments · Fixed by #185
Assignees
@jenny-s51
Labels
codemod pf5 codemod for p4 to p5 transition
Milestone
2023.01

Comments

@evwilkin
Copy link
Member

evwilkin commented Dec 7, 2022

Follow up to breaking change PR patternfly/patternfly-react#8220

The sticky deprecated prop has been removed from PageGroup and should be removed from consumers' code.

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@jenny-s51 jenny-s51 self-assigned this Dec 7, 2022
@nicolethoen nicolethoen added this to the 2023.01 milestone Dec 21, 2022
@jenny-s51 jenny-s51 mentioned this issue Dec 22, 2022
Merged
@jenny-s51 jenny-s51 linked a pull request Dec 22, 2022 that will close this issue
feat(page components): remove sticky prop #185
Merged
@gitdallas gitdallas added the pf5 codemod for p4 to p5 transition label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jenny-s51 jenny-s51

Labels
codemod pf5 codemod for p4 to p5 transition
Projects
PatternFly Issues
Archived in project
Milestone
2023.01
Development

Successfully merging a pull request may close this issue.

feat(page components): remove sticky prop patternfly/pf-codemods
4 participants
@gitdallas @evwilkin @nicolethoen @jenny-s51