Background image

[wise-king-sullyman]

No description provided.

[kmcfaul]

@wise-king-sullyman The current tests for background image look okay to me as far as the RTL practices, can you confirm?

[wise-king-sullyman]

I think it could be improved by updating the tests to be more like the Backdrop tests, i.e. checking that the default class name is the only class on it by default, that other props passed to it are properly placed, and that the structure stays consistent with a snapshot.

Also IMO the first test would ideally be split into two tests since the class assertion is a separate behavior than the styles.

That being said this is all much more minor/simpler stuff than most components, so if you want to put more focus on the significant updates needed elsewhere and leave this one up for a newer contributor (or just one less experienced with testing) I don't think that would be a bad idea.