Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - CodeSandbox demos - fix misc imports #9140

Closed
jenny-s51 opened this issue May 17, 2023 · 1 comment · Fixed by #9519
Closed

Bug - CodeSandbox demos - fix misc imports #9140

jenny-s51 opened this issue May 17, 2023 · 1 comment · Fixed by #9519
Assignees
Milestone

Comments

@jenny-s51
Copy link
Contributor

jenny-s51 commented May 17, 2023

Describe the problem
A clear and concise description of the problem. Which components are affected?
Follow up to patternfly/patternfly-org#3538

Icon import paths should be updated for relative path conversion logic to access/ import the correct icons within CodeSandbox demos.

  1. Icon import paths in Primary Detail Card View demo are not correct and CodeSandbox demo does not render the icons correctly

  2. Masthead fullscreen demo - imgAvatar and pfIcon not rendering correctly in CodeSandbox

  3. Application Launcher - demos that import pfLogoSm not rendering PF icons within dropdown items in CodeSandbox

  4. Compact table demo - Label, TableText not defined

  5. Static bottom pagination table demo - missing TableText import

  6. Sortable responsive demo - various missing imports

  7. Column management table demo - PageSection, Card not defined

  8. Filterable table demo - update table data import to import { rows, columns } from './sampleData';

  9. Primary detail card view - DashboardWrapper imported twice

Related: #9124

@github-project-automation github-project-automation bot moved this to Not started in PatternFly Issues May 17, 2023
@jenny-s51 jenny-s51 changed the title Bug - Primary Detail - fix icon import paths Bug - CodeSandbox demos - Fix icon import paths May 17, 2023
@jenny-s51 jenny-s51 self-assigned this May 17, 2023
@mcarrano mcarrano added this to the Post v5 priority milestone May 19, 2023
@evwilkin evwilkin self-assigned this Jul 12, 2023
@jenny-s51 jenny-s51 moved this from Not started to In Progress in PatternFly Issues Jul 13, 2023
@jenny-s51 jenny-s51 changed the title Bug - CodeSandbox demos - Fix icon import paths Bug - CodeSandbox demos - fix misc imports Aug 21, 2023
@jenny-s51 jenny-s51 moved this from In Progress to PR Review in PatternFly Issues Aug 21, 2023
@wise-king-sullyman wise-king-sullyman modified the milestones: 2023.Q3, 2023.Q4 Sep 12, 2023
@jenny-s51
Copy link
Contributor Author

Update: 1 - 3 moved to / now tracked in patternfly/patternfly-org#3757

@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants