Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pagination] - [Rename ToggleTemplateProps] #8122

Closed
tlabaj opened this issue Sep 29, 2022 · 4 comments · Fixed by #8134
Closed

[Pagination] - [Rename ToggleTemplateProps] #8122

tlabaj opened this issue Sep 29, 2022 · 4 comments · Fixed by #8134
Assignees
@KhanShaheb34
Labels
breaking change 💥 this change requires a major release and has API changes. good first issue PF5
Milestone
2022.15

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Sep 29, 2022

Describe the problem
A clear and concise description of the problem. Which components are affected?

rename ToggleTemplateProps to PaginationToggleTemplateProps. to matche naming practices
@tlabaj tlabaj added breaking change 💥 this change requires a major release and has API changes. needs triage labels Sep 29, 2022
@tlabaj tlabaj modified the milestones: Breaking Changes, 2022.15 Sep 29, 2022
@KhanShaheb34
Copy link
Contributor

Can you assign me please?

@KhanShaheb34 KhanShaheb34 mentioned this issue Oct 2, 2022
Merged
@tlabaj
Copy link
Contributor Author

tlabaj commented Oct 3, 2022

@KhanShaheb34 yes you can take this one. We will be spinning off a PatternFly5 branch this week. Once that is up, you will need make your pull request against the new branch.

@tlabaj tlabaj added PF5 and removed needs triage labels Oct 3, 2022
@KhanShaheb34
Copy link
Contributor

Ok.

@nicolethoen
Copy link
Contributor

Closed by #8134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KhanShaheb34 KhanShaheb34

Labels
breaking change 💥 this change requires a major release and has API changes. good first issue PF5
Projects
PatternFly Issues
Archived in project
Milestone
2022.15
3 participants
@nicolethoen @KhanShaheb34 @tlabaj