Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label/LabelGroup - update how editable labels are conveyed to assistive tech #8061

Closed
thatblindgeye opened this issue Sep 23, 2022 · 0 comments · Fixed by #8192
Closed

Label/LabelGroup - update how editable labels are conveyed to assistive tech #8061

thatblindgeye opened this issue Sep 23, 2022 · 0 comments · Fixed by #8192
Assignees
@jenny-s51
Labels
accessibility Feature end user feature that requires design to define this, i.e. changes or augments the user experience. good first issue Hacktoberfest 🎃
Milestone
2022.14

Comments

@thatblindgeye
Copy link
Contributor

Is this a new component or an extension of an existing one?
Label

Describe the feature
Currently editable labels in both Label and Label Group examples use aria-label to notify users that the Label is editable. This overrides the Label content, which can cause confusion/disparity since a "remove" button will reference the Label content (not the aria-label).

A quick solution would be to update examples so that the aria-label is concatenated from something along the lines of "Editable label: ${labelContent}

Are there visuals for this feature? If applicable, please include examples for each state and for varying widths
Include screenshots or links to Marvel or other mockups.

Any other information?
@thatblindgeye thatblindgeye added good first issue accessibility Feature end user feature that requires design to define this, i.e. changes or augments the user experience. needs triage labels Sep 23, 2022
@mcarrano mcarrano added this to the 2022.14 milestone Oct 4, 2022
@jenny-s51 jenny-s51 mentioned this issue Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jenny-s51 jenny-s51

Labels
accessibility Feature end user feature that requires design to define this, i.e. changes or augments the user experience. good first issue Hacktoberfest 🎃
Projects
PatternFly Issues
Archived in project
Milestone
2022.14
Development

Successfully merging a pull request may close this issue.

feat(label+labelGroup): update aria-labels to include label text jenny-s51/patternfly-react
4 participants
@mcarrano @jenny-s51 @tlabaj @thatblindgeye