Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label/LabelGroup - update how editable labels are conveyed to assistive tech #8061

Closed
thatblindgeye opened this issue Sep 23, 2022 · 0 comments · Fixed by #8192
Closed

Label/LabelGroup - update how editable labels are conveyed to assistive tech #8061

thatblindgeye opened this issue Sep 23, 2022 · 0 comments · Fixed by #8192

Comments

@thatblindgeye
Copy link
Contributor

Is this a new component or an extension of an existing one?
Label

Describe the feature
Currently editable labels in both Label and Label Group examples use aria-label to notify users that the Label is editable. This overrides the Label content, which can cause confusion/disparity since a "remove" button will reference the Label content (not the aria-label).

A quick solution would be to update examples so that the aria-label is concatenated from something along the lines of "Editable label: ${labelContent}

Are there visuals for this feature? If applicable, please include examples for each state and for varying widths
Include screenshots or links to Marvel or other mockups.

Any other information?

@mcarrano mcarrano added this to the 2022.14 milestone Oct 4, 2022
@nicolethoen nicolethoen moved this to Not started in PatternFly Issues Oct 5, 2022
@nicolethoen nicolethoen moved this from Not started to In Progress in PatternFly Issues Oct 10, 2022
@jenny-s51 jenny-s51 moved this from In Progress to PR Review in PatternFly Issues Oct 11, 2022
Repository owner moved this from PR Review to Done in PatternFly Issues Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants