Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - [Page] - [update onPageResize prop default value] #7861

Closed
tlabaj opened this issue Aug 18, 2022 · 3 comments
Closed

Bug - [Page] - [update onPageResize prop default value] #7861

tlabaj opened this issue Aug 18, 2022 · 3 comments
Assignees
Labels
Breaking change 💥 this change requires a major release and has API changes. Good first issue Hacktoberfest 🎃 PF5
Milestone

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Aug 18, 2022

Describe the problem
A clear and concise description of the problem. Which components are affected?
Update the default value for onPageResize
How do you reproduce the problem?
Resize observe get created even when there is not sidebar and consumer does not define onPageResize
See issue #7810 for more details

Is this issue blocking you?
List the workaround if there is one.
work around implemented in PR #7811

@tlabaj tlabaj added Breaking change 💥 this change requires a major release and has API changes. bug labels Aug 18, 2022
@tlabaj tlabaj added this to the Breaking Changes milestone Aug 18, 2022
@nicolethoen nicolethoen moved this to Breaking change in PatternFly Issues Sep 23, 2022
@tlabaj tlabaj modified the milestones: Breaking Changes, 2022.14 Sep 26, 2022
@nicolethoen nicolethoen moved this from Breaking change to Not started in PatternFly Issues Oct 5, 2022
@andyyvo
Copy link
Contributor

andyyvo commented Oct 5, 2022

@tlabaj @wise-king-sullyman from reading #7811 are we looking to remove onPageResize: (): void => null, under PageProps on line 104?

@wise-king-sullyman
Copy link
Contributor

@andyyvo yes I think that's correct, removing that default value so that the prop is undefined if it isn't passed.

Though additionally I would check and make sure that doing so doesn't cause any errors before you put the PR up, since it would if there's anywhere that we're relying on that default to be there.

@nicolethoen
Copy link
Contributor

Closed by #8203

Repository owner moved this from PR Review to Done in PatternFly Issues Oct 12, 2022
@nicolethoen nicolethoen added the PF5 label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change 💥 this change requires a major release and has API changes. Good first issue Hacktoberfest 🎃 PF5
Projects
Archived in project
Development

No branches or pull requests

4 participants