Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - ToolbarToggleGroup - Multiple ToolbarToggleGroups are not supported in the same toolbar #7590

Closed
TheRealJon opened this issue Jun 17, 2022 · 6 comments · Fixed by #9329
Assignees
Labels
bug P1 ⭐ top priority issues
Milestone

Comments

@TheRealJon
Copy link
Contributor

Describe the problem
If you include multiple ToolbarToggleGroup components in one Toolbar, all of the children of every ToolbarToggleGroup are displayed in the dropdown, even if they have different breakpoints

How do you reproduce the problem?
https://codesandbox.io/s/kind-night-e5mwfw

Expected behavior
Each ToolbarToggleGroup should only show its own children in the dropdown

Is this issue blocking you?
No.
Use other components like OverflowMenu to accomplish similar behavior

Screenshots
screencast-www patternfly org-2022 06 17-16_06_53

What is your environment?

  • OS: MacOS
  • Browser Chrome
  • Version 102.0.5005.115 (Official Build) (x86_64)

What is your product and what release date are you targeting?
OpenShift admin console, no target release date

Any other information?
N/A

@michpetrov
Copy link
Contributor

It looks like this kind of setup isn't supported. The way it's implemented a ToolbarContent comes with a single expandable container and a ToolbarToogleGroup will use that one instead of creating its own, so if you have multiples they will share it.

@stale
Copy link

stale bot commented Sep 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Sep 3, 2022
@nicolethoen nicolethoen self-assigned this Sep 13, 2022
@stale
Copy link

stale bot commented Nov 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Nov 13, 2022
@stale
Copy link

stale bot commented Jan 14, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 14, 2023
@stale
Copy link

stale bot commented Mar 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Mar 21, 2023
@nicolethoen nicolethoen added the Feature end user feature that requires design to define this, i.e. changes or augments the user experience. label Apr 27, 2023
@mcarrano mcarrano added bug and removed Feature end user feature that requires design to define this, i.e. changes or augments the user experience. enhancement 🚀 labels Jun 12, 2023
@tlabaj tlabaj added the P1 ⭐ top priority issues label Jun 20, 2023
@tlabaj tlabaj modified the milestones: Prioritized Backlog, 2023.Q3 Jun 20, 2023
@nicolethoen nicolethoen assigned kmcfaul and unassigned nicolethoen Jun 21, 2023
@stale
Copy link

stale bot commented Aug 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P1 ⭐ top priority issues
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants