Enforce type for children of Tabs component

[jonkoops]

The Tabs component can only accept children of the type of the Tab component. This is documented by a comment, but not enforced by TypeScript. To resolve this issue the correct type should be added so errors can be caught at compile time.

[nicolethoen]

The updates made in #6767 caused a type error in OpenShift. For now, the update was reverted to unblock the current release.

../console-app/src/components/user-preferences/UserPreferencePage.tsx:137:17 - error TS2322: Type 'ReactElement<TabProps, string | JSXElementConstructor<any>>[]' is not assignable to type '(TabsChild | TabsChild[]) & ReactNode'.
  Type 'ReactElement<TabProps, string | JSXElementConstructor<any>>[]' is not assignable to type 'TabsChild[]'.
    Type 'ReactElement<TabProps, string | JSXElementConstructor<any>>' is not assignable to type 'TabsChild'.
      Type 'ReactElement<TabProps, string | JSXElementConstructor<any>>' is not assignable to type 'TabElement'.
        Type 'string | JSXElementConstructor<any>' is not assignable to type 'JSXElementConstructor<TabProps>'.
          Type 'string' is not assignable to type 'JSXElementConstructor<TabProps>'.

137                 {userPreferenceTabs}
                    ~~~~~~~~~~~~~~~~~~~~

  ../../node_modules/@patternfly/react-core/dist/esm/components/Tabs/Tabs.d.ts:14:5
    14     children: TabsChild | TabsChild[];
           ~~~~~~~~
    The expected type comes from property 'children' which is declared here on type 'IntrinsicAttributes & IntrinsicClassAttributes<Tabs> & Pick<Readonly<TabsProps> & Readonly<{ children?: ReactNode; }>, "children"> & Partial<...> & Partial<...>'

[jonkoops]

@nicolethoen Interesting, does the code there actually work? Seem like they are using strings as children where they would not be possible.

[nicolethoen]

@tlabaj do we want to reopen the associated PR for this issue and merge it into the v5 branch?

[jonkoops]

@nicolethoen I've re-opened this PR targeting the v5 branch instead.

[nicolethoen]

Closed by #8217