Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF4: React Virtualized table follow up issue #2179

Closed
2 of 4 tasks
priley86 opened this issue Jun 6, 2019 · 2 comments
Closed
2 of 4 tasks

PF4: React Virtualized table follow up issue #2179

priley86 opened this issue Jun 6, 2019 · 2 comments
Labels
Milestone

Comments

@priley86
Copy link
Member

priley86 commented Jun 6, 2019

I would like to prerelease my changes in #2011 and begin testing downstream. There should be no breaking changes to @patternfly/react-table, however consumers should see the removal of Reactabular (reactabular-table) from their dependency tree.

Remaining things to circle back on later:

  • tests
  • convert flow js to typescript where necessary
  • a11y implementation for virtualized (t.b.d.)
  • fix Safari scrollbar in WindowScroller, this currently does not occur downstream (only in docs here) fixed in React-Virtualized PF4 tables #2011, padding should be applied for WindowScroller scrollbar
@rachael-phillips
Copy link
Contributor

@priley86 can we create two new issues. 1 for tests and 1 for the a11y work? The reason being we're hoping to assign these out to team members.

@priley86
Copy link
Member Author

done. Opened #2328 and #2329. Feel free to adjust accordingly @rachael-phillips :)

@rachael-phillips rachael-phillips added this to the Albatross milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants