Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masthead - updates to support better logo layout #10788

Closed
mcoker opened this issue Jul 22, 2024 · 2 comments · Fixed by #10809
Closed

Masthead - updates to support better logo layout #10788

mcoker opened this issue Jul 22, 2024 · 2 comments · Fixed by #10809
Assignees

Comments

@mcoker
Copy link
Contributor

mcoker commented Jul 22, 2024

Placeholder issue for patternfly/patternfly#6870

So far this update will just be to add a new container around the masthead toggle and logo, and rename a couple of containers within it.

@srambach
Copy link
Member

We've added a wrapper around the toggle and logo in the masthead. One wrinkle is that

  • the name masthead__main was repurposed as the wrapper
  • what was masthead__main is now masthead__brand
  • what was masthead__brand is now masthead__logo

Old structure of the masthead was:

masthead
  masthead__toggle
  masthead__main
    masthead__brand
  masthead__content

New structure of the masthead is:

masthead
  masthead__main
    masthead__toggle
    masthead__brand
      masthead__logo
  masthead__content

@tlabaj
Copy link
Contributor

tlabaj commented Jul 29, 2024

closed by #10809

@tlabaj tlabaj closed this as completed Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants