Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackToTop - full screen demo broken #10585

Closed
nicolethoen opened this issue Jun 10, 2024 · 4 comments · Fixed by #10818
Closed

BackToTop - full screen demo broken #10585

nicolethoen opened this issue Jun 10, 2024 · 4 comments · Fixed by #10818
Assignees

Comments

@nicolethoen
Copy link
Contributor

nicolethoen commented Jun 10, 2024

The full screen demo is not displaying the backToTop component.
https://staging-v6.patternfly.org/components/back-to-top/react-demos/using-name-selector/

I've noticed that the component is also not being displayed on staging-v6.surge.sh, i'm not sure if it's due to the same issue that's broken this demo. A followup issue in org might be necessary.

it also has two different scrollbars, is that intended?
@srambach @andrew-ronaldson @mcoker

@mcoker
Copy link
Contributor

mcoker commented Jun 11, 2024

I think the double scrollbars is maybe from <Page> as a child of <DashboardWrapper>?

<DashboardWrapper breadcrumb={null}>
<Page>
<PageSection variant={PageSectionVariants.light}>

@andrew-ronaldson
Copy link
Collaborator

I see there is a switch to turn on Always show BackToTopButton but is this demo supposed to show it only after scrolling?
The fake text about overpass should probably be changed since that is no longer accurate.

Screenshot 2024-06-11 at 9 27 11 AM

@nicolethoen
Copy link
Contributor Author

Ah - I was seeking a demo to show me how to make it appear on scroll because that was behavior that seemed broken on org. so if that's not the intention here, i still have to figure out why it's not working on the org side...

@tlabaj tlabaj added this to the Penta beta release milestone Jun 13, 2024
@mcoker
Copy link
Contributor

mcoker commented Jun 17, 2024

Discussed in a working session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants