Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nodeLinker: pnpm for Yarn installations #10548

Open
jonkoops opened this issue Jun 7, 2024 · 3 comments
Open

Use nodeLinker: pnpm for Yarn installations #10548

jonkoops opened this issue Jun 7, 2024 · 3 comments

Comments

@jonkoops
Copy link
Contributor

jonkoops commented Jun 7, 2024

This issue is a follow-up of #9959. In order to make the installation of packages more performant nodeLinker: pnpm should be configured for Yarn. This links the local node modules from a central content addressable store using symbolic links, avoiding an expensive copy operation. This has the added benefit of catching silly bugs such as phantom dependencies, which might lead to unexpected behaviour.

@jonkoops jonkoops added the DevX label Jun 7, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jun 7, 2024
@tlabaj tlabaj moved this from Needs triage to Needs info in PatternFly Issues Jun 13, 2024
Copy link

github-actions bot commented Aug 9, 2024

This issue has been automatically marked as stale because it has not had recent activity.

@github-actions github-actions bot added Stale and removed Stale labels Aug 9, 2024
@tlabaj tlabaj added the Pinned label Aug 12, 2024
@dlabaj dlabaj self-assigned this Aug 12, 2024
@dlabaj
Copy link
Contributor

dlabaj commented Aug 12, 2024

@tlabaj I think this is something worth getting in post v6. I don't think it would be much risk to add it during what we are doing now but with the release looming I wouldn't want to introduce right now. @jonkoops Let me know what you think.

@jonkoops
Copy link
Contributor Author

Yes, this a development enhancement that can wait until after v6.

@dlabaj dlabaj removed their assignment Sep 5, 2024
@kmcfaul kmcfaul removed the DevX label Oct 25, 2024
@tlabaj tlabaj moved this from Needs info to Backlog in PatternFly Issues Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

4 participants