From 705e9ffa0a41f3549b06bc05e210281f5a754df5 Mon Sep 17 00:00:00 2001
From: Jenny <32821331+jenny-s51@users.noreply.github.com>
Date: Tue, 14 Nov 2023 13:46:26 -0500
Subject: [PATCH] chore(misc): clean up instances of Array.apply (#9798)

* clean up instances of Array.apply

* rename item to value
---
 .../react-core/src/components/Nav/examples/NavFlyout.tsx  | 2 +-
 .../src/components/Nav/examples/NavHorizontalSubNav.tsx   | 2 +-
 .../src/components/Nav/examples/NavLegacyTertiary.tsx     | 2 +-
 .../components/Pagination/examples/PaginationSticky.tsx   | 4 ++--
 packages/react-core/src/demos/Banner.md                   | 8 ++++----
 .../src/demos/examples/BackToTop/BackToTopNameDemo.tsx    | 6 +++---
 .../Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx | 4 ++--
 packages/react-core/src/demos/examples/Nav/NavDefault.tsx | 2 +-
 .../react-core/src/demos/examples/Nav/NavExpandable.tsx   | 2 +-
 .../react-core/src/demos/examples/Nav/NavHorizontal.tsx   | 2 +-
 .../src/demos/examples/Nav/NavHorizontalWithSubnav.tsx    | 2 +-
 packages/react-core/src/demos/examples/Nav/NavManual.tsx  | 2 +-
 .../react-core/src/demos/examples/Nav/NavWithSubnav.tsx   | 2 +-
 .../src/demos/examples/Nav/deprecated/NavLight.tsx        | 2 +-
 .../src/demos/examples/Nav/deprecated/NavTertiary.tsx     | 2 +-
 .../demos/examples/Page/PageStickySectionBreadcrumb.tsx   | 4 ++--
 .../src/demos/examples/Page/PageStickySectionGroup.tsx    | 4 ++--
 .../examples/Page/PageStickySectionGroupAlternate.tsx     | 4 ++--
 packages/react-core/src/demos/examples/Wizard/InModal.tsx | 4 ++--
 .../src/components/demos/BackToTopDemo/BackToTopDemo.tsx  | 6 +++---
 20 files changed, 33 insertions(+), 33 deletions(-)

diff --git a/packages/react-core/src/components/Nav/examples/NavFlyout.tsx b/packages/react-core/src/components/Nav/examples/NavFlyout.tsx
index 9bcbed30be6..6e80b16ba9d 100644
--- a/packages/react-core/src/components/Nav/examples/NavFlyout.tsx
+++ b/packages/react-core/src/components/Nav/examples/NavFlyout.tsx
@@ -22,7 +22,7 @@ export const NavFlyout: React.FunctionComponent = () => {
           <MenuItem onClick={onMenuItemClick} flyoutMenu={children} itemId={`nav-flyout-next-menu-${depth}`}>
             Next menu
           </MenuItem>
-          {Array.apply(0, Array(numFlyouts - depth)).map((_item, index: number) => (
+          {Array.from({ length: numFlyouts - depth }).map((_value, index) => (
             <MenuItem
               onClick={onMenuItemClick}
               key={`${depth}-${index}`}
diff --git a/packages/react-core/src/components/Nav/examples/NavHorizontalSubNav.tsx b/packages/react-core/src/components/Nav/examples/NavHorizontalSubNav.tsx
index abcc5b594c2..2d2dd459ff2 100644
--- a/packages/react-core/src/components/Nav/examples/NavHorizontalSubNav.tsx
+++ b/packages/react-core/src/components/Nav/examples/NavHorizontalSubNav.tsx
@@ -11,7 +11,7 @@ export const NavHorizontalSubNav: React.FunctionComponent = () => {
   return (
     <Nav onSelect={onSelect} variant="horizontal-subnav" aria-label="Horizontal subnav local">
       <NavList>
-        {Array.apply(0, Array(10)).map(function (_item, index: number) {
+        {Array.from({ length: 10 }).map((_value, index) => {
           const num = index + 1;
           return (
             <NavItem
diff --git a/packages/react-core/src/components/Nav/examples/NavLegacyTertiary.tsx b/packages/react-core/src/components/Nav/examples/NavLegacyTertiary.tsx
index 7021c07ca41..d097cbd28c7 100644
--- a/packages/react-core/src/components/Nav/examples/NavLegacyTertiary.tsx
+++ b/packages/react-core/src/components/Nav/examples/NavLegacyTertiary.tsx
@@ -11,7 +11,7 @@ export const NavLegacyTertiary: React.FunctionComponent = () => {
   return (
     <Nav onSelect={onSelect} variant="tertiary" aria-label="Tertiary local">
       <NavList>
-        {Array.apply(0, Array(10)).map(function (_item, index: number) {
+        {Array.from({ length: 10 }).map(function (_value, index) {
           const num = index + 1;
           return (
             <NavItem
diff --git a/packages/react-core/src/components/Pagination/examples/PaginationSticky.tsx b/packages/react-core/src/components/Pagination/examples/PaginationSticky.tsx
index d44f130352d..7298b129a51 100644
--- a/packages/react-core/src/components/Pagination/examples/PaginationSticky.tsx
+++ b/packages/react-core/src/components/Pagination/examples/PaginationSticky.tsx
@@ -27,8 +27,8 @@ export const PaginationSticky: React.FunctionComponent = () => {
   const buildCards = () => {
     const numberOfCards = (page - 1) * perPage + perPage - 1 >= itemCount ? itemCount - (page - 1) * perPage : perPage;
 
-    return Array.apply(0, Array(numberOfCards)).map((x, i) => (
-      <GalleryItem key={i}>
+    return Array.from({ length: numberOfCards }).map((_value, index) => (
+      <GalleryItem key={index}>
         <Card>
           <CardBody>This is a card</CardBody>
         </Card>
diff --git a/packages/react-core/src/demos/Banner.md b/packages/react-core/src/demos/Banner.md
index 13fa3742747..d95c894f50f 100644
--- a/packages/react-core/src/demos/Banner.md
+++ b/packages/react-core/src/demos/Banner.md
@@ -58,9 +58,9 @@ class BannerDemo extends React.Component {
           </PageSection>
           <PageSection>
             <Gallery hasGutter>
-              {Array.apply(0, Array(30)).map((x, i) => (
-                <GalleryItem key={i}>
-                  <Card key={i}>
+              {Array.from({ length: 30 }).map((_value, index) => (
+                <GalleryItem key={index}>
+                  <Card key={index}>
                     <CardBody>This is a card</CardBody>
                   </Card>
                 </GalleryItem>
@@ -133,7 +133,7 @@ class BannerDemo extends React.Component {
               </PageSection>
               <PageSection>
                 <Gallery hasGutter>
-                  {Array.apply(0, Array(30)).map((x, i) => (
+                  {Array.from({ length: 30 }).map((_value, index) => (
                     <GalleryItem key={i}>
                       <Card key={i}>
                         <CardBody>This is a card</CardBody>
diff --git a/packages/react-core/src/demos/examples/BackToTop/BackToTopNameDemo.tsx b/packages/react-core/src/demos/examples/BackToTop/BackToTopNameDemo.tsx
index 14a1973345b..2ba9e164ad0 100644
--- a/packages/react-core/src/demos/examples/BackToTop/BackToTopNameDemo.tsx
+++ b/packages/react-core/src/demos/examples/BackToTop/BackToTopNameDemo.tsx
@@ -41,9 +41,9 @@ export const Name = () => {
           aria-label="Scrollable container of demonstration cards with a back to top element"
         >
           <Gallery hasGutter>
-            {Array.apply(0, Array(60)).map((_x: any, i: number) => (
-              <GalleryItem key={i}>
-                <Card key={i}>
+            {Array.from({ length: 60 }).map((_value, index) => (
+              <GalleryItem key={index}>
+                <Card key={index}>
                   <CardBody>
                     Lorem ipsum dolor sit amet, consectetur adipiscing elit. Maecenas fermentum et urna eget semper. Sed
                     tincidunt purus diam, id sollicitudin est pellentesque eget. Ut eget massa dignissim dolor pretium
diff --git a/packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx b/packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx
index eac1d3ac227..f42e60d3b24 100644
--- a/packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx
+++ b/packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx
@@ -543,8 +543,8 @@ export const MastheadWithUtilitiesAndUserDropdownMenu: React.FunctionComponent =
     >
       <PageSection>
         <Gallery hasGutter>
-          {Array.apply(0, Array(10)).map((x, i) => (
-            <GalleryItem key={i}>
+          {Array.from({ length: 10 }).map((_value, index) => (
+            <GalleryItem key={index}>
               <Card>
                 <CardBody>This is a card</CardBody>
               </Card>
diff --git a/packages/react-core/src/demos/examples/Nav/NavDefault.tsx b/packages/react-core/src/demos/examples/Nav/NavDefault.tsx
index e6ed9631325..06a03d14730 100644
--- a/packages/react-core/src/demos/examples/Nav/NavDefault.tsx
+++ b/packages/react-core/src/demos/examples/Nav/NavDefault.tsx
@@ -83,7 +83,7 @@ export const NavDefault: React.FunctionComponent = () => {
         </PageSection>
         <PageSection>
           <Gallery hasGutter>
-            {Array.from({ length: 10 }, (_value: any, index: React.Key) => (
+            {Array.from({ length: 10 }).map((_value, index) => (
               <GalleryItem key={index}>
                 <Card>
                   <CardBody>This is a card</CardBody>
diff --git a/packages/react-core/src/demos/examples/Nav/NavExpandable.tsx b/packages/react-core/src/demos/examples/Nav/NavExpandable.tsx
index 93ac5f83eba..708528bc139 100644
--- a/packages/react-core/src/demos/examples/Nav/NavExpandable.tsx
+++ b/packages/react-core/src/demos/examples/Nav/NavExpandable.tsx
@@ -109,7 +109,7 @@ export const NavExpandableDemo: React.FunctionComponent = () => {
         </PageSection>
         <PageSection>
           <Gallery hasGutter>
-            {Array.from({ length: 10 }, (_value: any, index: React.Key) => (
+            {Array.from({ length: 10 }).map((_value, index) => (
               <GalleryItem key={index}>
                 <Card>
                   <CardBody>This is a card</CardBody>
diff --git a/packages/react-core/src/demos/examples/Nav/NavHorizontal.tsx b/packages/react-core/src/demos/examples/Nav/NavHorizontal.tsx
index 7c9c41c4662..58a725fbe81 100644
--- a/packages/react-core/src/demos/examples/Nav/NavHorizontal.tsx
+++ b/packages/react-core/src/demos/examples/Nav/NavHorizontal.tsx
@@ -222,7 +222,7 @@ export const NavHorizontal: React.FunctionComponent = () => {
         </PageSection>
         <PageSection>
           <Gallery hasGutter>
-            {Array.from({ length: 10 }, (_value: any, index: React.Key) => (
+            {Array.from({ length: 10 }).map((_value, index) => (
               <GalleryItem key={index}>
                 <Card>
                   <CardBody>This is a card</CardBody>
diff --git a/packages/react-core/src/demos/examples/Nav/NavHorizontalWithSubnav.tsx b/packages/react-core/src/demos/examples/Nav/NavHorizontalWithSubnav.tsx
index 63465716fd9..863990f8cee 100644
--- a/packages/react-core/src/demos/examples/Nav/NavHorizontalWithSubnav.tsx
+++ b/packages/react-core/src/demos/examples/Nav/NavHorizontalWithSubnav.tsx
@@ -282,7 +282,7 @@ export const NavHorizontalWithSubnav: React.FunctionComponent = () => {
         </PageSection>
         <PageSection>
           <Gallery hasGutter>
-            {Array.from({ length: 10 }, (_value: any, index: React.Key) => (
+            {Array.from({ length: 10 }).map((_value, index) => (
               <GalleryItem key={index}>
                 <Card>
                   <CardBody>This is a card</CardBody>
diff --git a/packages/react-core/src/demos/examples/Nav/NavManual.tsx b/packages/react-core/src/demos/examples/Nav/NavManual.tsx
index 6824ed0d2ec..364d054b700 100644
--- a/packages/react-core/src/demos/examples/Nav/NavManual.tsx
+++ b/packages/react-core/src/demos/examples/Nav/NavManual.tsx
@@ -258,7 +258,7 @@ export const NavManual: React.FunctionComponent = () => {
         </PageSection>
         <PageSection>
           <Gallery hasGutter>
-            {Array.from({ length: 10 }, (_value: any, index: React.Key) => (
+            {Array.from({ length: 10 }).map((_value, index) => (
               <GalleryItem key={index}>
                 <Card>
                   <CardBody>This is a card</CardBody>
diff --git a/packages/react-core/src/demos/examples/Nav/NavWithSubnav.tsx b/packages/react-core/src/demos/examples/Nav/NavWithSubnav.tsx
index ac0624f4394..9d1cb28e99a 100644
--- a/packages/react-core/src/demos/examples/Nav/NavWithSubnav.tsx
+++ b/packages/react-core/src/demos/examples/Nav/NavWithSubnav.tsx
@@ -127,7 +127,7 @@ export const NavWithSubnav: React.FunctionComponent = () => {
         </PageSection>
         <PageSection>
           <Gallery hasGutter>
-            {Array.from({ length: 10 }, (_value: any, index: React.Key) => (
+            {Array.from({ length: 10 }).map((_value, index) => (
               <GalleryItem key={index}>
                 <Card>
                   <CardBody>This is a card</CardBody>
diff --git a/packages/react-core/src/demos/examples/Nav/deprecated/NavLight.tsx b/packages/react-core/src/demos/examples/Nav/deprecated/NavLight.tsx
index 2ccaf374bc2..36319469d97 100644
--- a/packages/react-core/src/demos/examples/Nav/deprecated/NavLight.tsx
+++ b/packages/react-core/src/demos/examples/Nav/deprecated/NavLight.tsx
@@ -81,7 +81,7 @@ export const NavLight: React.FunctionComponent = () => {
         </PageSection>
         <PageSection>
           <Gallery hasGutter>
-            {Array.from({ length: 10 }, (_value: any, index: React.Key) => (
+            {Array.from({ length: 10 }).map((_value, index) => (
               <GalleryItem key={index}>
                 <Card>
                   <CardBody>This is a card</CardBody>
diff --git a/packages/react-core/src/demos/examples/Nav/deprecated/NavTertiary.tsx b/packages/react-core/src/demos/examples/Nav/deprecated/NavTertiary.tsx
index 8ec5467f62d..edcca568fa3 100644
--- a/packages/react-core/src/demos/examples/Nav/deprecated/NavTertiary.tsx
+++ b/packages/react-core/src/demos/examples/Nav/deprecated/NavTertiary.tsx
@@ -77,7 +77,7 @@ export const NavTertiary: React.FunctionComponent = () => {
         </PageSection>
         <PageSection>
           <Gallery hasGutter>
-            {Array.from({ length: 10 }, (_value: any, index: React.Key) => (
+            {Array.from({ length: 10 }).map((_value, index) => (
               <GalleryItem key={index}>
                 <Card>
                   <CardBody>This is a card</CardBody>
diff --git a/packages/react-core/src/demos/examples/Page/PageStickySectionBreadcrumb.tsx b/packages/react-core/src/demos/examples/Page/PageStickySectionBreadcrumb.tsx
index 183ad9c1834..c8e1ac5abfc 100644
--- a/packages/react-core/src/demos/examples/Page/PageStickySectionBreadcrumb.tsx
+++ b/packages/react-core/src/demos/examples/Page/PageStickySectionBreadcrumb.tsx
@@ -278,8 +278,8 @@ export const PageStickySectionBreadcrumb: React.FunctionComponent = () => {
       </PageSection>
       <PageSection isWidthLimited>
         <Gallery hasGutter>
-          {Array.apply(0, Array(50)).map((_x, i) => (
-            <GalleryItem key={i}>
+          {Array.from({ length: 50 }).map((_value, index) => (
+            <GalleryItem key={index}>
               <Card>
                 <CardBody>This is a card</CardBody>
               </Card>
diff --git a/packages/react-core/src/demos/examples/Page/PageStickySectionGroup.tsx b/packages/react-core/src/demos/examples/Page/PageStickySectionGroup.tsx
index 91d632ceaa1..37df583365e 100644
--- a/packages/react-core/src/demos/examples/Page/PageStickySectionGroup.tsx
+++ b/packages/react-core/src/demos/examples/Page/PageStickySectionGroup.tsx
@@ -279,8 +279,8 @@ export const PageStickySectionGroup: React.FunctionComponent = () => {
     >
       <PageSection>
         <Gallery hasGutter>
-          {Array.apply(0, Array(50)).map((x, i) => (
-            <GalleryItem key={i}>
+          {Array.from({ length: 50 }).map((_value, index) => (
+            <GalleryItem key={index}>
               <Card>
                 <CardBody>This is a card</CardBody>
               </Card>
diff --git a/packages/react-core/src/demos/examples/Page/PageStickySectionGroupAlternate.tsx b/packages/react-core/src/demos/examples/Page/PageStickySectionGroupAlternate.tsx
index b94b797c6b5..2ec825a93e4 100644
--- a/packages/react-core/src/demos/examples/Page/PageStickySectionGroupAlternate.tsx
+++ b/packages/react-core/src/demos/examples/Page/PageStickySectionGroupAlternate.tsx
@@ -275,8 +275,8 @@ export const PageStickySectionGroupAlternate: React.FunctionComponent = () => {
       </PageGroup>
       <PageSection>
         <Gallery hasGutter>
-          {Array.apply(0, Array(50)).map((x, i) => (
-            <GalleryItem key={i}>
+          {Array.from({ length: 50 }).map((_value, index) => (
+            <GalleryItem key={index}>
               <Card>
                 <CardBody>This is a card</CardBody>
               </Card>
diff --git a/packages/react-core/src/demos/examples/Wizard/InModal.tsx b/packages/react-core/src/demos/examples/Wizard/InModal.tsx
index 0a6a9b424f5..a45410d12d7 100644
--- a/packages/react-core/src/demos/examples/Wizard/InModal.tsx
+++ b/packages/react-core/src/demos/examples/Wizard/InModal.tsx
@@ -18,8 +18,8 @@ export const WizardInModalDemo: React.FunctionComponent = () => (
     <DashboardWrapper hasPageTemplateTitle>
       <PageSection isWidthLimited>
         <Gallery hasGutter>
-          {Array.from({ length: 10 }).map((_, i) => (
-            <GalleryItem key={i}>
+          {Array.from({ length: 10 }).map((_value, index) => (
+            <GalleryItem key={index}>
               <Card>
                 <CardBody>This is a card</CardBody>
               </Card>
diff --git a/packages/react-integration/demo-app-ts/src/components/demos/BackToTopDemo/BackToTopDemo.tsx b/packages/react-integration/demo-app-ts/src/components/demos/BackToTopDemo/BackToTopDemo.tsx
index 71fbc88b94f..cb667533019 100644
--- a/packages/react-integration/demo-app-ts/src/components/demos/BackToTopDemo/BackToTopDemo.tsx
+++ b/packages/react-integration/demo-app-ts/src/components/demos/BackToTopDemo/BackToTopDemo.tsx
@@ -25,9 +25,9 @@ export const BackToTopDemo = () => (
     </PageSection>
     <PageSection hasOverflowScroll name="scrolling-section">
       <Gallery hasGutter>
-        {Array.apply(0, Array(60)).map((_x: any, i: number) => (
-          <GalleryItem key={i}>
-            <Card key={i}>
+        {Array.from({ length: 60 }).map((_value, index) => (
+          <GalleryItem key={index}>
+            <Card key={index}>
               <CardBody>
                 Lorem ipsum dolor sit amet, consectetur adipiscing elit. Maecenas fermentum et urna eget semper. Sed
                 tincidunt purus diam, id sollicitudin est pellentesque eget. Ut eget massa dignissim dolor pretium