From 6a457bb002780e2079520b9b84537bf66dae2ddb Mon Sep 17 00:00:00 2001 From: Tomas Psota Date: Tue, 11 Oct 2022 12:50:33 +0200 Subject: [PATCH] chore(Popover): remove deprecated props --- .../src/components/Popover/Popover.tsx | 17 +---------------- .../demos/PopoverDemo/PopoverDemo.tsx | 8 -------- 2 files changed, 1 insertion(+), 24 deletions(-) diff --git a/packages/react-core/src/components/Popover/Popover.tsx b/packages/react-core/src/components/Popover/Popover.tsx index e8d6c607014..0a258942190 100644 --- a/packages/react-core/src/components/Popover/Popover.tsx +++ b/packages/react-core/src/components/Popover/Popover.tsx @@ -16,7 +16,7 @@ import { ReactElement } from 'react'; import { FocusTrap } from '../../helpers'; import { Popper, getOpacityTransition } from '../../helpers/Popper/Popper'; import { getUniqueId } from '../../helpers/util'; -import { Instance as TippyInstance, Props as TippyProps } from '../../helpers/Popper/DeprecatedTippyTypes'; +import { Instance as TippyInstance } from '../../helpers/Popper/DeprecatedTippyTypes'; export enum PopoverPosition { auto = 'auto', @@ -60,10 +60,6 @@ export interface PopoverProps { * bodyContent={hide => } */ bodyContent: React.ReactNode | ((hide: () => void) => React.ReactNode); - /** @deprecated - no longer used. if you want to constrain the popper to a specific element - * use the appendTo prop instead. - */ - boundary?: 'scrollParent' | 'window' | 'viewport' | HTMLElement; /** * The reference element to which the popover is relatively placed to. If you cannot wrap * the reference with the Popover, you can use the reference prop instead. @@ -215,8 +211,6 @@ export interface PopoverProps { shouldOpen?: (showFunction?: () => void, event?: MouseEvent | KeyboardEvent) => void; /** Flag indicating whether the close button should be shown. */ showClose?: boolean; - /** @deprecated - no longer used. */ - tippyProps?: Partial; /** Whether to trap focus in the popover. */ withFocusTrap?: boolean; /** The z-index of the popover. */ @@ -265,21 +259,12 @@ export const Popover: React.FunctionComponent = ({ animationDuration = 300, id, withFocusTrap: propWithFocusTrap, - boundary, - tippyProps, reference, hasNoPadding = false, hasAutoWidth = false, removeFindDomNode = false, ...rest }: PopoverProps) => { - if (process.env.NODE_ENV !== 'production') { - boundary !== undefined && - console.warn( - 'The Popover boundary prop has been deprecated. If you want to constrain the popper to a specific element use the appendTo prop instead.' - ); - tippyProps !== undefined && console.warn('The Popover tippyProps prop has been deprecated and is no longer used.'); - } // could make this a prop in the future (true | false | 'toggle') // const hideOnClick = true; const uniqueId = id || getUniqueId(); diff --git a/packages/react-integration/demo-app-ts/src/components/demos/PopoverDemo/PopoverDemo.tsx b/packages/react-integration/demo-app-ts/src/components/demos/PopoverDemo/PopoverDemo.tsx index a53ec3f7fc2..56f8af16ab1 100644 --- a/packages/react-integration/demo-app-ts/src/components/demos/PopoverDemo/PopoverDemo.tsx +++ b/packages/react-integration/demo-app-ts/src/components/demos/PopoverDemo/PopoverDemo.tsx @@ -1,6 +1,5 @@ import { Popover } from '@patternfly/react-core'; import React, { Component } from 'react'; -import { Instance as TippyInstance } from '@patternfly/react-core/dist/esm/helpers/Popper/DeprecatedTippyTypes'; export class PopoverDemo extends Component { popoverRef: React.RefObject; @@ -30,13 +29,6 @@ export class PopoverDemo extends Component { > {this.myPopoverProps.children} - !tip} - > - -