From 36239847a72b4800d3c01647c1307c1d5fe5ceae Mon Sep 17 00:00:00 2001
From: Katie McFaul <kmcfaul@redhat.com>
Date: Mon, 6 Nov 2023 10:08:24 -0500
Subject: [PATCH] updates

---
 .../HelperText/__tests__/HelperText.test.tsx   | 18 ++++++++++++++----
 .../__tests__/HelperTextItem.test.tsx          |  9 +++++++++
 2 files changed, 23 insertions(+), 4 deletions(-)

diff --git a/packages/react-core/src/components/HelperText/__tests__/HelperText.test.tsx b/packages/react-core/src/components/HelperText/__tests__/HelperText.test.tsx
index 9cd354973f4..354ec0a4206 100644
--- a/packages/react-core/src/components/HelperText/__tests__/HelperText.test.tsx
+++ b/packages/react-core/src/components/HelperText/__tests__/HelperText.test.tsx
@@ -26,17 +26,22 @@ test('Renders default classes', () => {
 
 test('Renders id when id is passed', () => {
   render(<HelperText id="helper-id">text </HelperText>);
-  expect(screen.getByText('text')).toHaveAttribute('id');
+  expect(screen.getByText('text')).toHaveAttribute('id', 'helper-id');
 });
 
 test('Renders aria-live when isLiveRegion is passed', () => {
   render(<HelperText isLiveRegion>text </HelperText>);
-  expect(screen.getByText('text')).toHaveAttribute('aria-live');
+  expect(screen.getByText('text')).toHaveAttribute('aria-live', 'polite');
 });
 
-test('Spreads additional props when passed', () => {
+test('Does not render aria-live by default', () => {
   render(<HelperText>text </HelperText>);
-  expect(screen.getByText('text')).toBeInTheDocument();
+  expect(screen.getByText('text')).not.toHaveAttribute('aria-live');
+});
+
+test('Spreads additional props when passed', () => {
+  render(<HelperText dir="rtl">text </HelperText>);
+  expect(screen.getByText('text')).toHaveAttribute('dir', 'rtl');
 });
 
 test('Renders custom className', () => {
@@ -49,6 +54,11 @@ test('Renders with element passed to component prop', () => {
   expect(screen.getByText('text').tagName).toBe('UL');
 });
 
+test('Renders with div by default when no component prop is passed', () => {
+  render(<HelperText>text</HelperText>);
+  expect(screen.getByText('text').tagName).toBe('DIV');
+});
+
 test('Renders aria-label and role when component = ul', () => {
   render(
     <HelperText component="ul" aria-label="helper">
diff --git a/packages/react-core/src/components/HelperText/__tests__/HelperTextItem.test.tsx b/packages/react-core/src/components/HelperText/__tests__/HelperTextItem.test.tsx
index 25be563c595..321b2a6980f 100644
--- a/packages/react-core/src/components/HelperText/__tests__/HelperTextItem.test.tsx
+++ b/packages/react-core/src/components/HelperText/__tests__/HelperTextItem.test.tsx
@@ -83,3 +83,12 @@ test('Renders dynamic helper text', () => {
   expect(screen.getByText('help test text').parentElement).toHaveClass(styles.modifiers.dynamic);
   expect(screen.getByText('help test text').querySelector('span')).toHaveClass('pf-v5-screen-reader');
 });
+
+test('Renders custom screenreader text when isDynamic = true and screenReaderText is passed', () => {
+  render(
+    <HelperTextItem isDynamic screenReaderText="sr test">
+      help test text
+    </HelperTextItem>
+  );
+  expect(screen.getByText('help test text').querySelector('span')).toHaveTextContent('sr test');
+});