Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines updates: Icon #4487

Open
mcoker opened this issue Feb 27, 2025 · 0 comments
Open

Guidelines updates: Icon #4487

mcoker opened this issue Feb 27, 2025 · 0 comments

Comments

@mcoker
Copy link
Contributor

mcoker commented Feb 27, 2025

It would probably be helpful to have design guidelines for the <Icon> component. Something that came up recently is that the <Icon> component on its own will deliver an icon with our default icon font-size and color tokens. However, if the <Icon> is used somewhere a component already styles an <Icon> (like a button or a label), you want to use the isInline prop to tell the icon's font-size and color to inherit from it's parent context. We will be adding some docs to the component examples pages around this, but I wonder if this could also be touched on in design guidelines. At a minimum I think some guidelines around icon font-sizes and colors and how the <Icon> component allows you to customize those would be good.

cc @tlabaj @thatblindgeye @srambach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Status: No status
Development

No branches or pull requests

2 participants