Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL handbook - add any react specific documentation, other follow ups #3758

Closed
mcoker opened this issue Sep 19, 2023 · 1 comment · Fixed by #3767
Closed

RTL handbook - add any react specific documentation, other follow ups #3758

mcoker opened this issue Sep 19, 2023 · 1 comment · Fixed by #3767
Assignees
Milestone

Comments

@mcoker
Copy link
Contributor

mcoker commented Sep 19, 2023

Looks like we should probably add something about

cc @srambach @tlabaj @wise-king-sullyman @thatblindgeye @kmcfaul

@kmcfaul
Copy link
Contributor

kmcfaul commented Sep 21, 2023

Charts info for RTL:

  • Chart, ChartPie, ChartBullet, ChartDonut, ChartDonutUtilization all have a new legendDirection prop that should be set to rtl.
  • In the case of user defined custom legends that pass custom label components, rtl support would have to be done manually as legendDirection does not apply.
  • The ChartAxis representing the x-axis should additionally pass the invertAxis prop.

@wise-king-sullyman wise-king-sullyman moved this from Needs triage to Not started in PatternFly Issues Sep 22, 2023
@wise-king-sullyman wise-king-sullyman added this to the 2023.Q3 milestone Sep 22, 2023
@mcoker mcoker changed the title RTL handbook - add any react specific documentation RTL handbook - add any react specific documentation, other follow ups Sep 25, 2023
@edonehoo edonehoo self-assigned this Sep 27, 2023
@wise-king-sullyman wise-king-sullyman moved this from Not started to In Progress in PatternFly Issues Sep 28, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in PatternFly Issues Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants