Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ngx-bootstrap #279

Closed
dlabrecq opened this issue Jan 16, 2018 · 5 comments
Closed

Update ngx-bootstrap #279

dlabrecq opened this issue Jan 16, 2018 · 5 comments
Assignees

Comments

@dlabrecq
Copy link
Member

dlabrecq commented Jan 16, 2018

The current ngx-bootstrap dependency is locked at 1.8.0. This is because our unit tests break with version 1.9.3. That is, anything that tests an ngx-bootstrap drop down.

We had a problem with this before and added fixture.detectChanges() before each test as a workaround. That forces the drop down to render. Otherwise, the drop down is not available and the test fails. Essentially, the previous workaround is no longer valid.

In order to update ngx-bootstrap to use versions '^1.8.0', we would have to fix our unit tests first.

@dlabrecq
Copy link
Member Author

dlabrecq commented Jan 16, 2018

valor-software/ngx-bootstrap#2188

Tried updating zone.js as suggested, but no luck. Also updated other karma and jasmine dependencies with no change.

@seanforyou23 seanforyou23 self-assigned this Jan 16, 2018
@dlabrecq
Copy link
Member Author

A couple tests appear to be missing BsDropdownConfig as a provider - this is necessary for any test that uses a drop down.

@seanforyou23
Copy link
Contributor

Oops, forgot to close this issue! The two PR's mentioned above resolved it.

@iamade
Copy link

iamade commented Sep 17, 2020

please i am having this issue BsDropdownConfig as a provider on ngx-bootstrap 6.0.1, I need help in resolving it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants