Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins should be able to render individual patterns exactly as core would render them #1022

Open
aleksip opened this issue Jun 7, 2019 · 10 comments

Comments

@aleksip
Copy link
Member

aleksip commented Jun 7, 2019

Plugins might need to render a pattern that has not (yet) been rendered by core. Not 100 % sure but it looks like this could be done by calling the compose module? Or does some other way to do this 'right' exist?

If compose can be used, it looks like the same function writes the pattern to disk. It could be useful to decouple this from the rendering?

I haven't been able to find out if core checks whether a pattern has already been rendered or not. A check like this in core would be good for performance reasons if plugins are allowed to render patterns.

@stale
Copy link

stale bot commented Aug 7, 2019

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@sghoweri
Copy link
Contributor

Bump!

@stale
Copy link

stale bot commented Oct 11, 2019

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@aleksip
Copy link
Member Author

aleksip commented Oct 11, 2019

Bump

@bmuenzenmeyer
Copy link
Member

does a use case for this in-fact exist?

@aleksip
Copy link
Member Author

aleksip commented Oct 11, 2019

Yes, see the parent issue #1020. 🙂

@stale
Copy link

stale bot commented Dec 10, 2019

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@stale
Copy link

stale bot commented Jan 9, 2020

Issue closed after going stale. It can be re-opened if still relevant.

@stale stale bot closed this as completed Jan 9, 2020
@aleksip aleksip reopened this Aug 18, 2020
@stale
Copy link

stale bot commented Dec 19, 2020

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@stale
Copy link

stale bot commented Jan 9, 2022

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants