Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens if I have more than 1 deployment on the same repo? #7

Closed
felippepuhle opened this issue Dec 30, 2020 · 3 comments · Fixed by #8
Closed

What happens if I have more than 1 deployment on the same repo? #7

felippepuhle opened this issue Dec 30, 2020 · 3 comments · Fixed by #8
Labels
help wanted Extra attention is needed

Comments

@felippepuhle
Copy link
Contributor

For example, currently, I have the app itself and our storybook.

I tested a bit and it seems to use always the app preview URL, but I'm not sure if I can trust on that premise.

Is there a way I can guarantee that? This action would simplify a lot my workflow, it seems so great.

@felippepuhle
Copy link
Contributor Author

It just happened:

Screen Shot 2021-01-04 at 10 02 25 AM

Storybook was deployed first so it broke everything... can we create some kind of config to ensure that we're getting the correct deployment item? not sure which property from ReposListDeploymentStatusesResponseItem we should compare

@patrickedqvist
Copy link
Owner

Hello @felippepuhle,

Interesting, I haven't tried this myself. At the moment I'm afraid I don't have a lot of time on my hands (buried in client work) but make a fork and see if you can implement it yourself. Contributions are more than welcome.

My initial thoughts are that you need some information that is consistent with the deployment item so you can target for e.g storybook directly. I'm unaware of something as such exists from the Status Response Item. If there is it could be just adding a config array that you can filter those items against.

@patrickedqvist patrickedqvist added the help wanted Extra attention is needed label Jan 4, 2021
@felippepuhle
Copy link
Contributor Author

@patrickedqvist how can I debug it? can you help adding some explanation on the README so I can take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants