Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7.1 LogSubscriber color() deprecation #1261

Closed
rpheath opened this issue Jun 13, 2024 · 2 comments
Closed

Rails 7.1 LogSubscriber color() deprecation #1261

rpheath opened this issue Jun 13, 2024 · 2 comments

Comments

@rpheath
Copy link

rpheath commented Jun 13, 2024

In Rails 7.1 the color(...) method no longer accepts true as the third argument for "bold". Instead, you have to pass bold: true.

The LogSubscriber in thinking-sphinx has log output using the deprecated format, which results in a billion deprecation messages in application logs.

Is it possible to make an update to address this? Thanks!

@rpheath
Copy link
Author

rpheath commented Jun 13, 2024

Oh! I see that PR #1252 addresses this. Any chance it will be merged/released?

@pat
Copy link
Owner

pat commented Jul 7, 2024

Closing this as #1252 is merged (and hopefully will be released shortly!)

@pat pat closed this as completed Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants