From 38d699dbb1feb57323a6a4a423973d5292a68ebe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jean-Marie=20CL=C3=89RY?= Date: Thu, 17 Oct 2024 12:53:56 +0200 Subject: [PATCH] (PC-32484)[PRO] fix: Adds forgotten feature flag to PC-30946 and PC-31468 ! --- .../pages/VenueSettings/VenueSettingsForm.tsx | 39 ++++++++++++------- .../VenueSettings/VenueSettingsScreen.tsx | 37 ++++++++++-------- 2 files changed, 45 insertions(+), 31 deletions(-) diff --git a/pro/src/pages/VenueSettings/VenueSettingsForm.tsx b/pro/src/pages/VenueSettings/VenueSettingsForm.tsx index 00a55c7c9f7..25040b7c1da 100644 --- a/pro/src/pages/VenueSettings/VenueSettingsForm.tsx +++ b/pro/src/pages/VenueSettings/VenueSettingsForm.tsx @@ -14,6 +14,7 @@ import { resetAddressFields } from 'components/IndividualOfferForm/utils/resetAd import { RouteLeavingGuardIndividualOffer } from 'components/RouteLeavingGuardIndividualOffer/RouteLeavingGuardIndividualOffer' import { ScrollToFirstErrorAfterSubmit } from 'components/ScrollToFirstErrorAfterSubmit/ScrollToFirstErrorAfterSubmit' import { SelectOption } from 'custom_types/form' +import { useActiveFeature } from 'hooks/useActiveFeature' import fullBackIcon from 'icons/full-back.svg' import fullNextIcon from 'icons/full-next.svg' import { ReimbursementFields } from 'pages/Offerers/Offerer/VenueV1/fields/ReimbursementFields/ReimbursementFields' @@ -56,6 +57,8 @@ export const VenueSettingsForm = ({ const [manuallySetAddress, , { setValue: setManuallySetAddress }] = useField('manuallySetAddress') + const isOfferAddressEnabled = useActiveFeature('WIP_ENABLE_OFFER_ADDRESS') + const toggleManuallySetAddress = async () => { const isAddressManual = !manuallySetAddress.value await setManuallySetAddress(isAddressManual) @@ -107,21 +110,27 @@ export const VenueSettingsForm = ({ - - - - {manuallySetAddress.value && } + {isOfferAddressEnabled && ( + <> + + + + {manuallySetAddress.value && } + + )} )} diff --git a/pro/src/pages/VenueSettings/VenueSettingsScreen.tsx b/pro/src/pages/VenueSettings/VenueSettingsScreen.tsx index b2fb541bc71..d1d29ef365a 100644 --- a/pro/src/pages/VenueSettings/VenueSettingsScreen.tsx +++ b/pro/src/pages/VenueSettings/VenueSettingsScreen.tsx @@ -17,6 +17,7 @@ import { GET_VENUE_QUERY_KEY } from 'config/swrQueryKeys' import { Events } from 'core/FirebaseEvents/constants' import { PATCH_SUCCESS_MESSAGE } from 'core/shared/constants' import { SelectOption } from 'custom_types/form' +import { useActiveFeature } from 'hooks/useActiveFeature' import { useCurrentUser } from 'hooks/useCurrentUser' import { useNotification } from 'hooks/useNotification' import fullBackIcon from 'icons/full-back.svg' @@ -63,6 +64,8 @@ export const VenueSettingsScreen = ({ const [isAddressChangeDialogOpen, setIsAddressChangeDialogOpen] = useState(false) + const isOfferAddressEnabled = useActiveFeature('WIP_ENABLE_OFFER_ADDRESS') + const handleCancelWithdrawalDialog = () => { setShouldSendMail(false) formik.handleSubmit() @@ -128,7 +131,7 @@ export const VenueSettingsScreen = ({ const onSubmit = async (values: VenueSettingsFormValues) => { if ( (values.isWithdrawalAppliedOnAllOffers && !handleWithdrawalDialog()) || - !handleDialogAddressChange() + (!handleDialogAddressChange() && isOfferAddressEnabled) ) { return } @@ -236,21 +239,23 @@ export const VenueSettingsScreen = ({ title="Souhaitez-vous prévenir les bénéficiaires de la modification des modalités de retrait ?" open={isWithdrawalDialogOpen} /> - setIsAddressChangeDialogOpen(false)} - onConfirm={handleConfirmAddressChangeDialog} - icon={strokeErrorIcon} - title="Ce changement d'adresse ne va pas s'impacter sur vos offres" - open={isAddressChangeDialogOpen && venue.hasOffers} - > -

- Si vous souhaitez rectifier leur localisation, vous devez les - modifier individuellement. -

-
+ {isOfferAddressEnabled && ( + setIsAddressChangeDialogOpen(false)} + onConfirm={handleConfirmAddressChangeDialog} + icon={strokeErrorIcon} + title="Ce changement d'adresse ne va pas s'impacter sur vos offres" + open={isAddressChangeDialogOpen && venue.hasOffers} + > +

+ Si vous souhaitez rectifier leur localisation, vous devez les + modifier individuellement. +

+
+ )} )