-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding effective channel noises to digital basis #496
Comments
The idea is it to build effective channels on 3 dimensions then reduce it on the basis of interest'either rydberg/digital) using the partial trace? |
Yes, basically because it can be interesting to see how noise affects the results in digital mode. |
This one looks enjoyable! I'm giving it a shot, and expect a draft PR today. I'll likely ask for guidance at that point |
@Aaron-Robertson awesome, looking forward to it! |
I'm getting there @HGSilveri! It's been a more intense learning experience than anticipated 🤣 but I should actually have a draft today! |
Let me add a bit more clarification here. The objective is to generally run simulations with effective noise added to the system. Right now, this is only supported for the "ground-rydberg" basis, though we could envision it being extended to the "digital" basis relatively easily. |
Most of the work on this has already been done in PR #530. That PR has since been closed due to prolonged inactivity, but whoever picks this up in the future can base themselves on the work already done there. |
Currently, effective channel noises are implemented only for the Rydberg basis. A
NotImplementedError
is raised when a simulation is ran with aSimconfig
havingdetuning
ordephasing
noise.Implementing this feature would have an impact on simresults: the reduction of a density matrix to a basis is not implemented and cannot be tested because of the fact that no simulation can be performed with dimensions 3. This should be implemented using a partial_trace
The text was updated successfully, but these errors were encountered: