Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse interface update broke meshblockpacks #570

Closed
Yurlungur opened this issue Jul 23, 2021 · 1 comment · Fixed by #572
Closed

Sparse interface update broke meshblockpacks #570

Yurlungur opened this issue Jul 23, 2021 · 1 comment · Fixed by #572
Assignees
Labels
bug Something isn't working

Comments

@Yurlungur
Copy link
Collaborator

The following code snippet now fails

/ /MeshBlockData *rc provided above somewhere
PackIndexMap imap;
rc->PackVariables(names, imap);

with errors that look like

/parthenon/src/interface/mesh_data.hpp:296:5: error: no matching function for call to ‘parthenon::MeshBlockData<double>::PackVariables(const std::vector<std::__cxx11::basic_string<char> >&, parthenon::PackIndexMap&, parthenon::PackIndexMap&, std::vector<std::__cxx11::basic_string<char> >&)’

This function signature is obviously wrong. Somehow the PackIndexMap is getting passed in twice. I believe this is because the API

We didn't catch this because for MeshBlockPack we apparently don't test this particular call signature anywhere. This needs to change, as it is used everywhere in the downstream codes.

@Yurlungur Yurlungur added the bug Something isn't working label Jul 23, 2021
@Yurlungur
Copy link
Collaborator Author

I notice also that it's now no longer possible to pass the coarse boolean through the mesh_data PackVariables machinery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants