fix: query aggregation pipeline cannot handle value of type `Date` when `directAccess: true` #8167

dblythy · 2022-09-14T07:18:59Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Aggregation pipeline with dates do not work with directAccess

Related issue: #7748

Closes #7748

Approach

If a date is already a date in an aggregate pipeline, it should stay as a date. It is currently converted to {}

TODOs before merging

Add tests
A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

parse-github-assistant · 2022-09-14T07:19:04Z

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

dblythy · 2022-09-14T07:22:43Z

Ideally the failed test would be something along the lines of:

it('direct access should pass dates', async () => {
  await reconfigureServer({ directAccess: true });
  ...
});

However that doesn't result in the observed bug that occurs on real servers.

I have tested this fix on a real directAccess Parse Server and can confirm that aggregate with Date does not work before, but works after the change.

codecov · 2022-09-14T07:26:19Z

Codecov Report

Base: 94.21% // Head: 94.21% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b90caf2) compared to base (1d9605b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##            alpha    #8167   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files         182      182           
  Lines       13724    13726    +2     
=======================================
+ Hits        12930    12932    +2     
  Misses        794      794

Impacted Files	Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js	`93.19% <100.00%> (+0.02%)`	⬆️
src/RestWrite.js	`94.57% <0.00%> (-0.16%)`	⬇️
src/ParseServerRESTController.js	`98.48% <0.00%> (+1.51%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mtrezza · 2022-09-14T12:15:21Z

However that doesn't result in the observed bug that occurs on real servers.

Did you look at the test helper.js file, and the reconfigureServer() method? They may not set the option correctly, or not as if the option was set directly on the server.

dblythy · 2022-09-17T05:09:50Z

Did you look at the test helper.js file, and the reconfigureServer() method?

Yes I did, and it doesn't override directAccess at all

mtrezza · 2022-09-17T08:15:33Z

Yes I did, and it doesn't override directAccess at all

Maybe not overriding, but the way reconfigureServer works. To investigate, you could try to not use reconfigureServer but set direct access to true by default, so you would know whether the issue is with that method or something else in the test setup. If I recall correctly, reconfigureServer is a somewhat hacked together helper, so I guess would be the former.

I'm a bit hesitant to fix this without a test to prevent this bug from being reintroduced. Maybe you could take a 2nd look.

dblythy · 2022-09-17T08:27:41Z

reconfigureServer is called at the start of every test regardless, and it boots up a Parse Server with the default config. Even when I set directAccess to true, the Date object received is a string in the test suite. In real life, it's a Date. I'm not sure why this happens.

The test that I added makes sure that if a pipeline is used with a Date, the pipeline still works. This is the cause of the issue that directAccess: true introduced.

mtrezza · 2022-09-17T11:53:43Z

The test that I added makes sure that if a pipeline is used with a Date, the pipeline still works. This is the cause of the issue that directAccess: true introduced.

Maybe I misunderstood your comment, so there is a test that prevents this from being re-introduced?

dblythy · 2022-09-17T12:37:33Z

Yes, I added a test for that 😊 I didn't want coverage to go down either

mtrezza

Looks good!

# [5.3.0-alpha.24](5.3.0-alpha.23...5.3.0-alpha.24) (2022-09-17) ### Bug Fixes * query aggregation pipeline cannot handle value of type `Date` when `directAccess: true` ([#8167](#8167)) ([e424137](e424137))

parseplatformorg · 2022-09-17T14:27:08Z

🎉 This change has been released in version 5.3.0-alpha.24

# [5.4.0-beta.1](5.3.0...5.4.0-beta.1) (2022-10-29) ### Bug Fixes * authentication adapter app ID validation may be circumvented; this fixes a vulnerability that affects configurations which allow users to authenticate using the Parse Server authentication adapter for *Facebook* or *Spotify* and where the server-side authentication adapter configuration `appIds` is set as a string (e.g. `abc`) instead of an array of strings (e.g. `["abc"]`) ([GHSA-r657-33vp-gp22](GHSA-r657-33vp-gp22)) [skip release] ([#8187](#8187)) ([8c8ec71](8c8ec71)) * brute force guessing of user sensitive data via search patterns (GHSA-2m6g-crv8-p3c6) ([#8146](#8146)) [skip release] ([4c0c7c7](4c0c7c7)) * certificate in Apple Game Center auth adapter not validated [skip release] ([#8058](#8058)) ([75af9a2](75af9a2)) * graphQL query ignores condition `equalTo` with value `false` ([#8032](#8032)) ([7f5a15d](7f5a15d)) * internal indices for classes `_Idempotency` and `_Role` are not protected in defined schema ([#8121](#8121)) ([c16f529](c16f529)) * invalid file request not properly handled [skip release] ([#8062](#8062)) ([4c9e956](4c9e956)) * liveQuery with `containedIn` not working when object field is an array ([#8128](#8128)) ([1d9605b](1d9605b)) * protected fields exposed via LiveQuery (GHSA-crrq-vr9j-fxxh) [skip release] ([#8076](#8076)) ([9fd4516](9fd4516)) * push notifications `badge` doesn't update with Installation beforeSave trigger ([#8162](#8162)) ([3c75c2b](3c75c2b)) * query aggregation pipeline cannot handle value of type `Date` when `directAccess: true` ([#8167](#8167)) ([e424137](e424137)) * relation constraints in compound queries `Parse.Query.or`, `Parse.Query.and` not working ([#8203](#8203)) ([28f0d26](28f0d26)) * security upgrade undici from 5.6.0 to 5.8.0 ([#8108](#8108)) ([4aa016b](4aa016b)) * server crashes when receiving file download request with invalid byte range; this fixes a security vulnerability that allows an attacker to impact the availability of the server instance; the fix improves parsing of the range parameter to properly handle invalid range requests ([GHSA-h423-w6qv-2wj3](GHSA-h423-w6qv-2wj3)) [skip release] ([#8238](#8238)) ([c03908f](c03908f)) * session object properties can be updated by foreign user; this fixes a security vulnerability in which a foreign user can write to the session object of another user if the session object ID is known; the fix prevents writing to foreign session objects ([GHSA-6w4q-23cf-j9jp](GHSA-6w4q-23cf-j9jp)) [skip release] ([#8180](#8180)) ([37fed30](37fed30)) * sorting by non-existing value throws `INVALID_SERVER_ERROR` on Postgres ([#8157](#8157)) ([3b775a1](3b775a1)) * updating object includes unchanged keys in client response for certain key types ([#8159](#8159)) ([37af1d7](37af1d7)) ### Features * add convenience access to Parse Server configuration in Cloud Code via `Parse.Server` ([#8244](#8244)) ([9f11115](9f11115)) * add option to change the default value of the `Parse.Query.limit()` constraint ([#8152](#8152)) ([0388956](0388956)) * add support for MongoDB 6 ([#8242](#8242)) ([aba0081](aba0081)) * add support for Postgres 15 ([#8215](#8215)) ([2feb6c4](2feb6c4)) * liveQuery support for unsorted distance queries ([#8221](#8221)) ([0f763da](0f763da))

parseplatformorg · 2022-10-29T20:07:26Z

🎉 This change has been released in version 5.4.0-beta.1

# [5.4.0-alpha.1](5.3.0...5.4.0-alpha.1) (2022-10-31) ### Bug Fixes * authentication adapter app ID validation may be circumvented; this fixes a vulnerability that affects configurations which allow users to authenticate using the Parse Server authentication adapter for *Facebook* or *Spotify* and where the server-side authentication adapter configuration `appIds` is set as a string (e.g. `abc`) instead of an array of strings (e.g. `["abc"]`) ([GHSA-r657-33vp-gp22](GHSA-r657-33vp-gp22)) [skip release] ([#8187](#8187)) ([8c8ec71](8c8ec71)) * brute force guessing of user sensitive data via search patterns (GHSA-2m6g-crv8-p3c6) ([#8146](#8146)) [skip release] ([4c0c7c7](4c0c7c7)) * certificate in Apple Game Center auth adapter not validated [skip release] ([#8058](#8058)) ([75af9a2](75af9a2)) * graphQL query ignores condition `equalTo` with value `false` ([#8032](#8032)) ([7f5a15d](7f5a15d)) * internal indices for classes `_Idempotency` and `_Role` are not protected in defined schema ([#8121](#8121)) ([c16f529](c16f529)) * invalid file request not properly handled [skip release] ([#8062](#8062)) ([4c9e956](4c9e956)) * liveQuery with `containedIn` not working when object field is an array ([#8128](#8128)) ([1d9605b](1d9605b)) * protected fields exposed via LiveQuery (GHSA-crrq-vr9j-fxxh) [skip release] ([#8076](#8076)) ([9fd4516](9fd4516)) * push notifications `badge` doesn't update with Installation beforeSave trigger ([#8162](#8162)) ([3c75c2b](3c75c2b)) * query aggregation pipeline cannot handle value of type `Date` when `directAccess: true` ([#8167](#8167)) ([e424137](e424137)) * relation constraints in compound queries `Parse.Query.or`, `Parse.Query.and` not working ([#8203](#8203)) ([28f0d26](28f0d26)) * security upgrade undici from 5.6.0 to 5.8.0 ([#8108](#8108)) ([4aa016b](4aa016b)) * server crashes when receiving file download request with invalid byte range; this fixes a security vulnerability that allows an attacker to impact the availability of the server instance; the fix improves parsing of the range parameter to properly handle invalid range requests ([GHSA-h423-w6qv-2wj3](GHSA-h423-w6qv-2wj3)) [skip release] ([#8238](#8238)) ([c03908f](c03908f)) * session object properties can be updated by foreign user; this fixes a security vulnerability in which a foreign user can write to the session object of another user if the session object ID is known; the fix prevents writing to foreign session objects ([GHSA-6w4q-23cf-j9jp](GHSA-6w4q-23cf-j9jp)) [skip release] ([#8180](#8180)) ([37fed30](37fed30)) * sorting by non-existing value throws `INVALID_SERVER_ERROR` on Postgres ([#8157](#8157)) ([3b775a1](3b775a1)) * updating object includes unchanged keys in client response for certain key types ([#8159](#8159)) ([37af1d7](37af1d7)) ### Features * add convenience access to Parse Server configuration in Cloud Code via `Parse.Server` ([#8244](#8244)) ([9f11115](9f11115)) * add option to change the default value of the `Parse.Query.limit()` constraint ([#8152](#8152)) ([0388956](0388956)) * add support for MongoDB 6 ([#8242](#8242)) ([aba0081](aba0081)) * add support for Postgres 15 ([#8215](#8215)) ([2feb6c4](2feb6c4)) * liveQuery support for unsorted distance queries ([#8221](#8221)) ([0f763da](0f763da))

parseplatformorg · 2022-10-31T14:43:54Z

🎉 This change has been released in version 5.4.0-alpha.1

# [5.4.0](5.3.3...5.4.0) (2022-11-19) ### Bug Fixes * authentication adapter app ID validation may be circumvented; this fixes a vulnerability that affects configurations which allow users to authenticate using the Parse Server authentication adapter for *Facebook* or *Spotify* and where the server-side authentication adapter configuration `appIds` is set as a string (e.g. `abc`) instead of an array of strings (e.g. `["abc"]`) ([GHSA-r657-33vp-gp22](GHSA-r657-33vp-gp22)) [skip release] ([#8187](#8187)) ([8c8ec71](8c8ec71)) * brute force guessing of user sensitive data via search patterns (GHSA-2m6g-crv8-p3c6) ([#8146](#8146)) [skip release] ([4c0c7c7](4c0c7c7)) * certificate in Apple Game Center auth adapter not validated [skip release] ([#8058](#8058)) ([75af9a2](75af9a2)) * graphQL query ignores condition `equalTo` with value `false` ([#8032](#8032)) ([7f5a15d](7f5a15d)) * internal indices for classes `_Idempotency` and `_Role` are not protected in defined schema ([#8121](#8121)) ([c16f529](c16f529)) * invalid file request not properly handled [skip release] ([#8062](#8062)) ([4c9e956](4c9e956)) * liveQuery with `containedIn` not working when object field is an array ([#8128](#8128)) ([1d9605b](1d9605b)) * protected fields exposed via LiveQuery (GHSA-crrq-vr9j-fxxh) [skip release] ([#8076](#8076)) ([9fd4516](9fd4516)) * push notifications `badge` doesn't update with Installation beforeSave trigger ([#8162](#8162)) ([3c75c2b](3c75c2b)) * query aggregation pipeline cannot handle value of type `Date` when `directAccess: true` ([#8167](#8167)) ([e424137](e424137)) * relation constraints in compound queries `Parse.Query.or`, `Parse.Query.and` not working ([#8203](#8203)) ([28f0d26](28f0d26)) * security upgrade undici from 5.6.0 to 5.8.0 ([#8108](#8108)) ([4aa016b](4aa016b)) * server crashes when receiving file download request with invalid byte range; this fixes a security vulnerability that allows an attacker to impact the availability of the server instance; the fix improves parsing of the range parameter to properly handle invalid range requests ([GHSA-h423-w6qv-2wj3](GHSA-h423-w6qv-2wj3)) [skip release] ([#8238](#8238)) ([c03908f](c03908f)) * session object properties can be updated by foreign user; this fixes a security vulnerability in which a foreign user can write to the session object of another user if the session object ID is known; the fix prevents writing to foreign session objects ([GHSA-6w4q-23cf-j9jp](GHSA-6w4q-23cf-j9jp)) [skip release] ([#8180](#8180)) ([37fed30](37fed30)) * sorting by non-existing value throws `INVALID_SERVER_ERROR` on Postgres ([#8157](#8157)) ([3b775a1](3b775a1)) * updating object includes unchanged keys in client response for certain key types ([#8159](#8159)) ([37af1d7](37af1d7)) ### Features * add convenience access to Parse Server configuration in Cloud Code via `Parse.Server` ([#8244](#8244)) ([9f11115](9f11115)) * add option to change the default value of the `Parse.Query.limit()` constraint ([#8152](#8152)) ([0388956](0388956)) * add support for MongoDB 6 ([#8242](#8242)) ([aba0081](aba0081)) * add support for Postgres 15 ([#8215](#8215)) ([2feb6c4](2feb6c4)) * liveQuery support for unsorted distance queries ([#8221](#8221)) ([0f763da](0f763da))

parseplatformorg · 2022-11-19T03:44:02Z

🎉 This change has been released in version 5.4.0

parseplatformorg · 2022-11-19T11:49:35Z

🎉 This change has been released in version 5.4.0

* authentication adapter app ID validation may be circumvented; this fixes a vulnerability that affects configurations which allow users to authenticate using the Parse Server authentication adapter for *Facebook* or *Spotify* and where the server-side authentication adapter configuration `appIds` is set as a string (e.g. `abc`) instead of an array of strings (e.g. `["abc"]`) ([GHSA-r657-33vp-gp22](GHSA-r657-33vp-gp22)) [skip release] ([parse-community#8187](parse-community#8187)) ([8c8ec71](parse-community@8c8ec71)) * brute force guessing of user sensitive data via search patterns (GHSA-2m6g-crv8-p3c6) ([parse-community#8146](parse-community#8146)) [skip release] ([4c0c7c7](parse-community@4c0c7c7)) * certificate in Apple Game Center auth adapter not validated [skip release] ([parse-community#8058](parse-community#8058)) ([75af9a2](parse-community@75af9a2)) * graphQL query ignores condition `equalTo` with value `false` ([parse-community#8032](parse-community#8032)) ([7f5a15d](parse-community@7f5a15d)) * internal indices for classes `_Idempotency` and `_Role` are not protected in defined schema ([parse-community#8121](parse-community#8121)) ([c16f529](parse-community@c16f529)) * invalid file request not properly handled [skip release] ([parse-community#8062](parse-community#8062)) ([4c9e956](parse-community@4c9e956)) * liveQuery with `containedIn` not working when object field is an array ([parse-community#8128](parse-community#8128)) ([1d9605b](parse-community@1d9605b)) * protected fields exposed via LiveQuery (GHSA-crrq-vr9j-fxxh) [skip release] ([parse-community#8076](parse-community#8076)) ([9fd4516](parse-community@9fd4516)) * push notifications `badge` doesn't update with Installation beforeSave trigger ([parse-community#8162](parse-community#8162)) ([3c75c2b](parse-community@3c75c2b)) * query aggregation pipeline cannot handle value of type `Date` when `directAccess: true` ([parse-community#8167](parse-community#8167)) ([e424137](parse-community@e424137)) * relation constraints in compound queries `Parse.Query.or`, `Parse.Query.and` not working ([parse-community#8203](parse-community#8203)) ([28f0d26](parse-community@28f0d26)) * security upgrade undici from 5.6.0 to 5.8.0 ([parse-community#8108](parse-community#8108)) ([4aa016b](parse-community@4aa016b)) * server crashes when receiving file download request with invalid byte range; this fixes a security vulnerability that allows an attacker to impact the availability of the server instance; the fix improves parsing of the range parameter to properly handle invalid range requests ([GHSA-h423-w6qv-2wj3](GHSA-h423-w6qv-2wj3)) [skip release] ([parse-community#8238](parse-community#8238)) ([c03908f](parse-community@c03908f)) * session object properties can be updated by foreign user; this fixes a security vulnerability in which a foreign user can write to the session object of another user if the session object ID is known; the fix prevents writing to foreign session objects ([GHSA-6w4q-23cf-j9jp](GHSA-6w4q-23cf-j9jp)) [skip release] ([parse-community#8180](parse-community#8180)) ([37fed30](parse-community@37fed30)) * sorting by non-existing value throws `INVALID_SERVER_ERROR` on Postgres ([parse-community#8157](parse-community#8157)) ([3b775a1](parse-community@3b775a1)) * updating object includes unchanged keys in client response for certain key types ([parse-community#8159](parse-community#8159)) ([37af1d7](parse-community@37af1d7)) * add convenience access to Parse Server configuration in Cloud Code via `Parse.Server` ([parse-community#8244](parse-community#8244)) ([9f11115](parse-community@9f11115)) * add option to change the default value of the `Parse.Query.limit()` constraint ([parse-community#8152](parse-community#8152)) ([0388956](parse-community@0388956)) * add support for MongoDB 6 ([parse-community#8242](parse-community#8242)) ([aba0081](parse-community@aba0081)) * add support for Postgres 15 ([parse-community#8215](parse-community#8215)) ([2feb6c4](parse-community@2feb6c4)) * liveQuery support for unsorted distance queries ([parse-community#8221](parse-community#8221)) ([0f763da](parse-community@0f763da))

fix: aggregate doesn't allow dates with directAccess

a5895b5

mtrezza changed the title ~~fix: aggregate doesn't allow dates with directAccess~~ fix: query aggregation pipeline doesn't work with values of type Date when directAccess: true Sep 14, 2022

mtrezza changed the title ~~fix: query aggregation pipeline doesn't work with values of type Date when directAccess: true~~ fix: query aggregation pipeline doesn't work with value of type Date when directAccess: true Sep 14, 2022

mtrezza changed the title ~~fix: query aggregation pipeline doesn't work with value of type Date when directAccess: true~~ fix: query aggregation pipeline cannot handle value of type Date when directAccess: true Sep 14, 2022

dblythy and others added 2 commits September 15, 2022 01:02

Merge branch 'alpha' into aggregate

1887202

Merge branch 'alpha' into aggregate

b9cd047

dblythy requested a review from a team September 17, 2022 05:10

Merge branch 'alpha' into aggregate

d379e2f

Merge branch 'alpha' into aggregate

b90caf2

mtrezza approved these changes Sep 17, 2022

View reviewed changes

mtrezza merged commit e424137 into parse-community:alpha Sep 17, 2022

parseplatformorg added the state:released-alpha Released as alpha version label Sep 17, 2022

dblythy deleted the aggregate branch September 17, 2022 14:29

parseplatformorg added the state:released-beta Released as beta version label Oct 29, 2022

parseplatformorg added the state:released Released as stable version label Nov 19, 2022

parseplatformorg added the state:released-5.x.x Released as LTS version label Nov 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: query aggregation pipeline cannot handle value of type `Date` when `directAccess: true` #8167

fix: query aggregation pipeline cannot handle value of type `Date` when `directAccess: true` #8167

dblythy commented Sep 14, 2022 •

edited

Loading

parse-github-assistant bot commented Sep 14, 2022 •

edited

Loading

dblythy commented Sep 14, 2022 •

edited

Loading

codecov bot commented Sep 14, 2022 •

edited

Loading

mtrezza commented Sep 14, 2022 •

edited

Loading

dblythy commented Sep 17, 2022

mtrezza commented Sep 17, 2022 •

edited

Loading

dblythy commented Sep 17, 2022 •

edited

Loading

mtrezza commented Sep 17, 2022

dblythy commented Sep 17, 2022

mtrezza left a comment

parseplatformorg commented Sep 17, 2022

parseplatformorg commented Oct 29, 2022

parseplatformorg commented Oct 31, 2022

parseplatformorg commented Nov 19, 2022

parseplatformorg commented Nov 19, 2022

fix: query aggregation pipeline cannot handle value of type Date when directAccess: true #8167

fix: query aggregation pipeline cannot handle value of type Date when directAccess: true #8167

Conversation

dblythy commented Sep 14, 2022 • edited Loading

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

parse-github-assistant bot commented Sep 14, 2022 • edited Loading

Thanks for opening this pull request!

dblythy commented Sep 14, 2022 • edited Loading

codecov bot commented Sep 14, 2022 • edited Loading

Codecov Report

mtrezza commented Sep 14, 2022 • edited Loading

dblythy commented Sep 17, 2022

mtrezza commented Sep 17, 2022 • edited Loading

dblythy commented Sep 17, 2022 • edited Loading

mtrezza commented Sep 17, 2022

dblythy commented Sep 17, 2022

mtrezza left a comment

Choose a reason for hiding this comment

parseplatformorg commented Sep 17, 2022

parseplatformorg commented Oct 29, 2022

parseplatformorg commented Oct 31, 2022

parseplatformorg commented Nov 19, 2022

parseplatformorg commented Nov 19, 2022

fix: query aggregation pipeline cannot handle value of type `Date` when `directAccess: true` #8167

fix: query aggregation pipeline cannot handle value of type `Date` when `directAccess: true` #8167

dblythy commented Sep 14, 2022 •

edited

Loading

parse-github-assistant bot commented Sep 14, 2022 •

edited

Loading

dblythy commented Sep 14, 2022 •

edited

Loading

codecov bot commented Sep 14, 2022 •

edited

Loading

mtrezza commented Sep 14, 2022 •

edited

Loading

mtrezza commented Sep 17, 2022 •

edited

Loading

dblythy commented Sep 17, 2022 •

edited

Loading