Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add maven publications to configure the Jitpack releases #1128

Merged
merged 3 commits into from
Oct 14, 2021
Merged

fix: add maven publications to configure the Jitpack releases #1128

merged 3 commits into from
Oct 14, 2021

Conversation

azlekov
Copy link
Contributor

@azlekov azlekov commented Oct 14, 2021 •
edited
Loading

New Pull Request Checklist

Issue Description

Related issue: #1124
Closes: #1124

Approach

Followed the Jitpack documentation and Android Maven Publication guide. Introduced two publications - for debug and for release,

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 14, 2021 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@azlekov azlekov requested a review from mtrezza October 14, 2021 08:01
@azlekov azlekov self-assigned this Oct 14, 2021
@codecov
Copy link

codecov bot commented Oct 14, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@25b4f34). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head ef1360b differs from pull request most recent head 2dff208. Consider uploading reports for the commit 2dff208 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1128   +/-   ##
=========================================
  Coverage          ?   65.28%           
  Complexity        ?     2218           
=========================================
  Files             ?      122           
  Lines             ?     9957           
  Branches          ?     1337           
=========================================
  Hits              ?     6500           
  Misses            ?     2945           
  Partials          ?      512

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25b4f34...2dff208. Read the comment docs.

@azlekov
Copy link
Contributor Author

azlekov commented Oct 14, 2021

@mtrezza this should fix JitPack releases. Can you take a look over it.

@azlekov azlekov removed their assignment Oct 14, 2021
mtrezza
mtrezza approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza changed the title ci: add maven publications to configure the Jitpack releases fix: add maven publications to configure the Jitpack releases Oct 14, 2021
@mtrezza mtrezza merged commit 67c4fb6 into parse-community:master Oct 14, 2021
parseplatformorg pushed a commit that referenced this pull request Oct 14, 2021
@semantic-release-bot
chore(release): 2.0.1 [skip ci]
fd6ca1e 
## [2.0.1](2.0.0...2.0.1) (2021-10-14)

### Bug Fixes

* add maven publications to configure the Jitpack releases ([#1128](#1128)) ([67c4fb6](67c4fb6))
@parseplatformorg
Copy link

🎉 This pull request has been released in version 2.0.1

@parseplatformorg parseplatformorg added the state:released Released as stable version label Oct 14, 2021
parseplatformorg pushed a commit that referenced this pull request Oct 14, 2021
@semantic-release-bot
chore(release): 2.0.1 [skip ci]
0d54b49 
## [2.0.1](2.0.0...2.0.1) (2021-10-14)

### Bug Fixes

* add maven publications to configure the Jitpack releases ([#1128](#1128)) ([67c4fb6](67c4fb6))
@parseplatformorg
Copy link

🎉 This pull request has been released in version 2.0.1

github-actions bot pushed a commit to mtrezza/Parse-SDK-Android that referenced this pull request Oct 14, 2021
@semantic-release-bot
chore(release): 2.0.1 [skip ci]
64bcb3b 
## [2.0.1](2.0.0...2.0.1) (2021-10-14)

### Bug Fixes

* add maven publications to configure the Jitpack releases ([parse-community#1128](https://github.com/mtrezza/Parse-SDK-Android/issues/1128)) ([67c4fb6](67c4fb6))
parseplatformorg pushed a commit that referenced this pull request Oct 14, 2021
@semantic-release-bot
chore(release): 2.0.1 [skip ci]
4249c0e 
## [2.0.1](2.0.0...2.0.1) (2021-10-14)

### Bug Fixes

* add maven publications to configure the Jitpack releases ([#1128](#1128)) ([67c4fb6](67c4fb6))
github-actions bot pushed a commit to mtrezza/Parse-SDK-Android that referenced this pull request Oct 14, 2021
@semantic-release-bot
chore(release): 2.0.1 [skip ci]
bbf70ae 
## [2.0.1](2.0.0...2.0.1) (2021-10-14)

### Bug Fixes

* add maven publications to configure the Jitpack releases ([parse-community#1128](https://github.com/mtrezza/Parse-SDK-Android/issues/1128)) ([67c4fb6](67c4fb6))
@parseplatformorg
Copy link

🎉 This pull request has been released in version 2.0.1

github-actions bot pushed a commit to mtrezza/Parse-SDK-Android that referenced this pull request Oct 14, 2021
@semantic-release-bot
chore(release): 2.0.1 [skip ci]
1a86ba4 
## [2.0.1](2.0.0...2.0.1) (2021-10-14)

### Bug Fixes

* add maven publications to configure the Jitpack releases ([parse-community#1128](https://github.com/mtrezza/Parse-SDK-Android/issues/1128)) ([67c4fb6](67c4fb6))
parseplatformorg pushed a commit that referenced this pull request Oct 14, 2021
@semantic-release-bot
chore(release): 2.0.1 [skip ci]
b4d56ae 
## [2.0.1](2.0.0...2.0.1) (2021-10-14)

### Bug Fixes

* add maven publications to configure the Jitpack releases ([#1128](#1128)) ([67c4fb6](67c4fb6))
* Parse Android SDK 2.0.0 not building on jitpack ([#1129](#1129)) ([5d40917](5d40917))
github-actions bot pushed a commit to mtrezza/Parse-SDK-Android that referenced this pull request Oct 14, 2021
@semantic-release-bot
chore(release): 2.0.1 [skip ci]
b854bd6 
## [2.0.1](2.0.0...2.0.1) (2021-10-14)

### Bug Fixes

* add maven publications to configure the Jitpack releases ([parse-community#1128](https://github.com/mtrezza/Parse-SDK-Android/issues/1128)) ([67c4fb6](67c4fb6))
* Parse Android SDK 2.0.0 not building on jitpack ([parse-community#1129](https://github.com/mtrezza/Parse-SDK-Android/issues/1129)) ([5d40917](5d40917))
parseplatformorg pushed a commit that referenced this pull request Oct 14, 2021
@semantic-release-bot
chore(release): 2.0.1 [skip ci]
fd20702 
## [2.0.1](2.0.0...2.0.1) (2021-10-14)

### Bug Fixes

* add maven publications to configure the Jitpack releases ([#1128](#1128)) ([67c4fb6](67c4fb6))
* Parse Android SDK 2.0.0 not building on jitpack ([#1129](#1129)) ([5d40917](5d40917))
@parseplatformorg
Copy link

🎉 This pull request has been released in version 2.0.1

@azlekov azlekov deleted the #1124-cannot-update-to-latest-android-sdk-version-2-0-0 branch October 15, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot update to latest Android SDK version 2.0.0
3 participants
@azlekov @parseplatformorg @mtrezza